public inbox for binutils@sourceware.org
 help / color / mirror / Atom feed
From: "H.J. Lu" <hjl.tools@gmail.com>
To: binutils@sourceware.org
Subject: [PATCH 5/7] binutils: Add --remove-section-header tests
Date: Mon,  9 Mar 2020 17:12:22 -0700	[thread overview]
Message-ID: <20200310001224.131714-7-hjl.tools@gmail.com> (raw)
In-Reply-To: <20200310001224.131714-1-hjl.tools@gmail.com>

Verify --remove-section-header with objcopy and strip is ignored for
relocatable file.

	PR ld/25617
	* testsuite/binutils-all/objcopy.exp: Verify
	--remove-section-header ignored for relocatable file.
	* testsuite/binutils-all/remove-header-1.d: New file.
---
 binutils/testsuite/binutils-all/objcopy.exp       | 13 +++++++++++++
 binutils/testsuite/binutils-all/remove-header-1.d |  8 ++++++++
 2 files changed, 21 insertions(+)
 create mode 100644 binutils/testsuite/binutils-all/remove-header-1.d

diff --git a/binutils/testsuite/binutils-all/objcopy.exp b/binutils/testsuite/binutils-all/objcopy.exp
index 549b064e96..11bb8fea84 100644
--- a/binutils/testsuite/binutils-all/objcopy.exp
+++ b/binutils/testsuite/binutils-all/objcopy.exp
@@ -1115,6 +1115,13 @@ if [is_elf_format] {
 	run_dump_test "note-6-32"
     }
     run_dump_test "note-5"
+
+    set saved_OBJCOPYFLAGS $OBJCOPYFLAGS
+    append OBJCOPYFLAGS " --remove-section-header"
+
+    objcopy_test "simple copy with --remove-section-header" bintest.s
+
+    set OBJCOPYFLAGS $saved_OBJCOPYFLAGS
 }
 
 run_dump_test "copy-2"
@@ -1231,6 +1238,12 @@ if [is_elf_format] {
         verbose [file rootname $t]
         run_dump_test [file rootname $t]
     }
+
+    # Test --remove-section-header
+    run_dump_test "remove-header-1" \
+			[list \
+			  [list source strip-15${reloc_format}.s] \
+			  [list as "${elf64} --defsym RELOC=${reloc}"]]
 }
 run_dump_test "localize-hidden-2"
 
diff --git a/binutils/testsuite/binutils-all/remove-header-1.d b/binutils/testsuite/binutils-all/remove-header-1.d
new file mode 100644
index 0000000000..60a9c407af
--- /dev/null
+++ b/binutils/testsuite/binutils-all/remove-header-1.d
@@ -0,0 +1,8 @@
+#PROG: strip
+#strip: -g --remove-section-header
+#readelf: -r
+
+Relocation section '\.rela?\.text' at offset .* contains 2 entries:
+ *Offset * Info * Type * Sym\. *Value * Sym\. *Name(?: * \+ * Addend)?
+0+00 * 0+0(?:1|b|32|103) * R_[^ ]* *(?: * 55aa)?
+#pass
-- 
2.24.1


  parent reply	other threads:[~2020-03-10  0:12 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-03-10  0:12 [PATCH 0/7] ELF: Omit section header on ELF objects H.J. Lu
2020-03-10  0:12 ` [PATCH 1/7] ELF: Omit section header in " H.J. Lu
2020-03-10  0:12 ` [PATCH 1/7] ELF: Omit section header on " H.J. Lu
2020-03-20  7:11   ` Alan Modra
2020-03-10  0:12 ` [PATCH 2/7] bfd: Improve nm and objdump without section header H.J. Lu
2020-03-12  3:11   ` Fangrui Song
2020-03-10  0:12 ` [PATCH 3/7] readelf: Compute dynamic symbol table size from hash table H.J. Lu
2020-03-10  0:12 ` [PATCH 4/7] ld: Add a simple test for -z nosectionheader H.J. Lu
2020-03-10  0:12 ` H.J. Lu [this message]
2020-03-10  0:12 ` [PATCH 6/7] ld: Add tests for -z nosectionheader and --remove-section-header H.J. Lu
2020-03-10  0:12 ` [PATCH 7/7] ld: Add -z nosectionheader test to bootstrap.exp H.J. Lu
  -- strict thread matches above, loose matches on Subject: below --
2020-03-08 23:42 [PATCH 0/7] ELF: Don't require section header on ELF objects H.J. Lu
2020-03-08 23:42 ` [PATCH 5/7] binutils: Add --remove-section-header tests H.J. Lu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200310001224.131714-7-hjl.tools@gmail.com \
    --to=hjl.tools@gmail.com \
    --cc=binutils@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).