From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pj1-x1041.google.com (mail-pj1-x1041.google.com [IPv6:2607:f8b0:4864:20::1041]) by sourceware.org (Postfix) with ESMTPS id 51BCD387102A for ; Sat, 14 Mar 2020 09:53:22 +0000 (GMT) Received: by mail-pj1-x1041.google.com with SMTP id hg10so1486120pjb.1 for ; Sat, 14 Mar 2020 02:53:22 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=ZPlEbvaK2G/bRlJPta0JoqoIPAKIvbTPdPqzMGOdNLs=; b=Y6Zu+UJvXdbl7DYgoTSkySY11m1ZozRFID55++De8x8cJa/iRBDuH9zpQYTks+4KKj Tp6eazSxcyYDWeJfC/QRSvXSgmzMyvRLzOiz12ZB5cFbmQGkKwEcr9sN9qbEjnsEBIi0 K0pTIjKG9TJTkpFavHlAdGxPPqaJusbW8CbEPuurC2xu7CCzs6QLEkbvYXWzLlOd3DXU 71bxIIlld3W7KDpRkOjNDx+i2i3cyLzmZ0WiLIjVAgK2pfD5snMoJ9ahBipwGoAsYEhz 8Xac0rwBiTrVhp8AOeSZIIs0Rjn9vCPOIQN6nXs7qjHdc/ZXd0DR6EJULS+OxMCrw+OY mNXA== X-Gm-Message-State: ANhLgQ0dT+hPuTQbqBMO4bCWWkgq953kEtWmXnFzsaoZSEozkT5f4J9k q9EznWvWArIqYV6izhtTiQwYnrrC0vk= X-Google-Smtp-Source: ADFU+vvNS3oiqAACqhEr6Yz541293HOMLlLtf6sNSV1CpIKlHBITOyiqmlE08GMBoYQtgO2LmA1kLA== X-Received: by 2002:a17:90a:264f:: with SMTP id l73mr14004393pje.92.1584179601096; Sat, 14 Mar 2020 02:53:21 -0700 (PDT) Received: from bubble.grove.modra.org (158.106.96.58.static.exetel.com.au. [58.96.106.158]) by smtp.gmail.com with ESMTPSA id b2sm6572492pjc.6.2020.03.14.02.53.19 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 14 Mar 2020 02:53:20 -0700 (PDT) Received: by bubble.grove.modra.org (Postfix, from userid 1000) id B3DDE89EA4; Sat, 14 Mar 2020 20:23:16 +1030 (ACDT) Date: Sat, 14 Mar 2020 20:23:16 +1030 From: Alan Modra To: binutils@sourceware.org Subject: Re: asan: more readelf leaks Message-ID: <20200314095316.GI23597@bubble.grove.modra.org> References: <20200313035547.GJ5384@bubble.grove.modra.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200313035547.GJ5384@bubble.grove.modra.org> User-Agent: Mutt/1.9.4 (2018-02-28) X-Spam-Status: No, score=-25.2 required=5.0 tests=DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, FREEMAIL_FROM, GIT_PATCH_0, GIT_PATCH_1, GIT_PATCH_2, GIT_PATCH_3, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: binutils@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Binutils mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 14 Mar 2020 09:53:23 -0000 In git commit fd486f32d15e I put some static variables used by get_symbol_for_build_attribute in a file scope ba_cache struct. This was to prevent leaks in get_symbol_for_build_attribute, and to tidy up before readelf exited. The patch wasn't quite right though. When readelf processes more than one file it was possible to double free arrays allocated in get_symbol_for_build_attribute. * readelf.c (process_file): Clean ba_cache. diff --git a/binutils/readelf.c b/binutils/readelf.c index 0f8a0809c5..49eb20f28c 100644 --- a/binutils/readelf.c +++ b/binutils/readelf.c @@ -20571,7 +20571,9 @@ process_file (char * file_name) free (filedata); free (ba_cache.strtab); + ba_cache.strtab = NULL; free (ba_cache.symtab); + ba_cache.symtab = NULL; ba_cache.filedata = NULL; return ret; -- Alan Modra Australia Development Lab, IBM