From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pj1-x1035.google.com (mail-pj1-x1035.google.com [IPv6:2607:f8b0:4864:20::1035]) by sourceware.org (Postfix) with ESMTPS id DC8BB385E00D for ; Sun, 22 Mar 2020 12:56:51 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org DC8BB385E00D Received: by mail-pj1-x1035.google.com with SMTP id hg10so4794586pjb.1 for ; Sun, 22 Mar 2020 05:56:51 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:subject:message-id:mime-version :content-disposition:user-agent; bh=t1l9SyhtCG1bQvqWd+EQH4wHQ5E3moPgVJMHGazUz88=; b=ducNbCR2H+sAO9xcYHPVksbi0AsrOhukoKJ2eA4qVuJ2WVyZ93zmGIdGgkYZSDIvJ9 kmGyH7feizyeyuOUqEyeEwq5Nmfde+21Lh3TyL4ud0idjlaVqmpksuUaTJgQR/HuoEZa H9rdyNIyttCTh0NYDxmgEpKUF+B6imhcCgQIvyQ6E4aXH9I/QkuAL1JITQEEFJ43rlEW UdtfBF3BxByk84unmttaCI3eoB6cW1yPkULov1sDT0fm8+B+XUwcAzZ10YOtp7iEKl+Q ONzrtOCIkYbw6lG50u3HcRsza8rSH4Z27MO5HRjPRyvhylmDkFiM1UD45v7/d+hl+27W Hjaw== X-Gm-Message-State: ANhLgQ1XriWNFvoZl2yOGzbmZB51D19Mk6h6plcRNkeFUb7SxrDgX1aa JKE4XnibHvujzUsYcGEGDbWoos1F850= X-Google-Smtp-Source: ADFU+vti3ePlDVh1Y5xt89FQRnpKL2yfNZxdP5FJ3lAXNot0uJwwMoI6KZhnfR5hiM1GP/4TLBq+0w== X-Received: by 2002:a17:90a:e7c8:: with SMTP id kb8mr19444950pjb.79.1584881810713; Sun, 22 Mar 2020 05:56:50 -0700 (PDT) Received: from bubble.grove.modra.org ([2406:3400:51d:8cc0:6120:5ee0:cb93:ed00]) by smtp.gmail.com with ESMTPSA id t1sm9718155pgh.88.2020.03.22.05.56.49 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 22 Mar 2020 05:56:50 -0700 (PDT) Received: by bubble.grove.modra.org (Postfix, from userid 1000) id 0268788E40; Sun, 22 Mar 2020 23:26:46 +1030 (ACDT) Date: Sun, 22 Mar 2020 23:26:46 +1030 From: Alan Modra To: binutils@sourceware.org Subject: XCOFF64 uninitialised read Message-ID: <20200322125646.GR4583@bubble.grove.modra.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline User-Agent: Mutt/1.9.4 (2018-02-28) X-Spam-Status: No, score=-26.3 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, FREEMAIL_FROM, GIT_PATCH_0, GIT_PATCH_1, GIT_PATCH_2, GIT_PATCH_3, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: binutils@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Binutils mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 22 Mar 2020 12:56:53 -0000 Like git commit 67338173a4. * coff64-rs6000.c (xcoff64_slurp_armap): Ensure size is large enough to read number of symbols. diff --git a/bfd/coff64-rs6000.c b/bfd/coff64-rs6000.c index cca876eb4e..d34e25903c 100644 --- a/bfd/coff64-rs6000.c +++ b/bfd/coff64-rs6000.c @@ -1933,9 +1933,9 @@ xcoff64_slurp_armap (bfd *abfd) return FALSE; sz = bfd_scan_vma (hdr.size, (const char **) NULL, 10); - if (sz == (bfd_size_type) -1) + if (sz + 1 < 9) { - bfd_set_error (bfd_error_no_memory); + bfd_set_error (bfd_error_bad_value); return FALSE; } -- Alan Modra Australia Development Lab, IBM