From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pj1-x1043.google.com (mail-pj1-x1043.google.com [IPv6:2607:f8b0:4864:20::1043]) by sourceware.org (Postfix) with ESMTPS id 274BB385B834 for ; Tue, 24 Mar 2020 21:51:49 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 274BB385B834 Received: by mail-pj1-x1043.google.com with SMTP id o12so123041pjs.2 for ; Tue, 24 Mar 2020 14:51:49 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=kDWHkm6QXTJkfQAe+3EuDBHdwAVm+P50jdXvtXauEEo=; b=uNR05FfalRNScM2XG7SiYNzvJzZ68DqienZWoy665NzcbMkgvkIqy0ofIfhvkTVyxS 8t6wlvhUWwVQZgSpHCxCvg2FejAlAm0ocPMXn2zb7QaWh9wqjsrwBGXlvrSvuneZBwsS NjFCdF8E0tSulxYnPOSTdrezFzt+CUYtUaur/LFz4Y4dLtrV8r62dyPECCiAVAWqgv31 IQ+VvckygfSf+u6hTst3YqPYoJ2/vSbr5XOYvduCNc/UN/p/GmP0dIgPAhZCeEU1PYOt INpDOga+9hnchElv8I+5Ih2380uLIgsEDD5DgkTQkUiLTTJt9C3yPr9G86Ns0FWXvR9T 1idA== X-Gm-Message-State: ANhLgQ0W7kFn9h1q2Gp2RxYbMhLYF5zr9f82hkSnjWUHo6QNMEk8fs4o ojehnrLU1rVp7seAXe7apOPPxM1nEFo= X-Google-Smtp-Source: ADFU+vtX7RoGxabLwnJZj21G91bnRsbEG3usrdkxhIh1h8eq6SHAHPOwRyO6JQzNBmeIo9jjPNZ/2w== X-Received: by 2002:a17:902:7d91:: with SMTP id a17mr64353plm.267.1585086708306; Tue, 24 Mar 2020 14:51:48 -0700 (PDT) Received: from bubble.grove.modra.org ([2406:3400:51d:8cc0:9135:eada:4ebe:7d15]) by smtp.gmail.com with ESMTPSA id nu13sm3318221pjb.22.2020.03.24.14.51.47 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 24 Mar 2020 14:51:47 -0700 (PDT) Received: by bubble.grove.modra.org (Postfix, from userid 1000) id F4084806D7; Wed, 25 Mar 2020 08:21:43 +1030 (ACDT) Date: Wed, 25 Mar 2020 08:21:43 +1030 From: Alan Modra To: "H.J. Lu" Cc: Nick Clifton , Binutils Subject: Re: [PATCH] bfd: Add a bfd_boolean argument to bfd_get_symbol_version_string Message-ID: <20200324215143.GY4583@bubble.grove.modra.org> References: <20200322122947.270417-1-hjl.tools@gmail.com> <55e72288-5cdd-1c6d-4ac9-d8f0042ea318@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.9.4 (2018-02-28) X-Spam-Status: No, score=-11.6 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, FREEMAIL_FROM, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: binutils@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Binutils mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 24 Mar 2020 21:51:50 -0000 On Tue, Mar 24, 2020 at 10:47:58AM -0700, H.J. Lu via Binutils wrote: > We can't call _bfd_elf_get_symbol_version_name from nm.c since it isn't > available for all target configurations. This patch add a bfd_boolean > argument to bfd_get_symbol_version_string instead. > > OK for master? OK. -- Alan Modra Australia Development Lab, IBM