* [PATCH] arc: Use correct string when printing bfd DEBUG data
@ 2020-03-24 14:25 Shahab Vahedi
2020-03-25 5:14 ` Alan Modra
0 siblings, 1 reply; 2+ messages in thread
From: Shahab Vahedi @ 2020-03-24 14:25 UTC (permalink / raw)
To: binutils; +Cc: Shahab Vahedi, Claudiu Zissulescu, Francois Bedard
From: Shahab Vahedi <shahab@synopsys.com>
PRINT_DEBUG_RELOC_INFO_BEFORE() macro prints bunch of parameters
for debugging purposes. Due to a seemingly copy/paste mistake,
the "input_section->vma" is printed under the field name
"symbol_section->vma". This commit fixes that.
This fix is a courtesy of xiangzhai.
bfd/ChangeLog
2020-03-24 Shahab Vahedi <shahab@synopsys.com>
* elf32-arc.c (PRINT_DEBUG_RELOC_INFO_BEFORE): Use the
correct field name in the output string.
---
bfd/ChangeLog | 5 +++++
bfd/elf32-arc.c | 4 ++--
2 files changed, 7 insertions(+), 2 deletions(-)
diff --git a/bfd/ChangeLog b/bfd/ChangeLog
index d9e1139eb1a..8e841b42745 100644
--- a/bfd/ChangeLog
+++ b/bfd/ChangeLog
@@ -1,3 +1,8 @@
+2020-03-24 Shahab Vahedi <shahab@synopsys.com>
+
+ * elf32-arc.c (PRINT_DEBUG_RELOC_INFO_BEFORE): Use the
+ correct field name in the output string.
+
2020-03-24 Nick Clifton <nickc@redhat.com>
PR 25681
diff --git a/bfd/elf32-arc.c b/bfd/elf32-arc.c
index 5179fc370c4..df6e3c4e193 100644
--- a/bfd/elf32-arc.c
+++ b/bfd/elf32-arc.c
@@ -1255,11 +1255,11 @@ arc_special_overflow_checks (const struct arc_relocation_data reloc_data,
else \
ARC_DEBUG ("symbol_section->vma = NULL\n"); \
if (input_section->output_section != NULL) \
- ARC_DEBUG ("symbol_section->vma = %#lx\n", \
+ ARC_DEBUG ("input_section->vma = %#lx\n", \
input_section->output_section->vma \
+ input_section->output_offset); \
else \
- ARC_DEBUG ("symbol_section->vma = NULL\n"); \
+ ARC_DEBUG ("input_section->vma = NULL\n"); \
ARC_DEBUG ("PCL = %#lx\n", P); \
ARC_DEBUG ("P = %#lx\n", P); \
ARC_DEBUG ("G = %#lx\n", G); \
--
2.26.0
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH] arc: Use correct string when printing bfd DEBUG data
2020-03-24 14:25 [PATCH] arc: Use correct string when printing bfd DEBUG data Shahab Vahedi
@ 2020-03-25 5:14 ` Alan Modra
0 siblings, 0 replies; 2+ messages in thread
From: Alan Modra @ 2020-03-25 5:14 UTC (permalink / raw)
To: Shahab Vahedi
Cc: binutils, Shahab Vahedi, Claudiu Zissulescu, Francois Bedard
On Tue, Mar 24, 2020 at 03:25:24PM +0100, Shahab Vahedi via Binutils wrote:
> * elf32-arc.c (PRINT_DEBUG_RELOC_INFO_BEFORE): Use the
> correct field name in the output string.
Applied.
--
Alan Modra
Australia Development Lab, IBM
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2020-03-25 5:14 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-03-24 14:25 [PATCH] arc: Use correct string when printing bfd DEBUG data Shahab Vahedi
2020-03-25 5:14 ` Alan Modra
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).