From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pj1-x1031.google.com (mail-pj1-x1031.google.com [IPv6:2607:f8b0:4864:20::1031]) by sourceware.org (Postfix) with ESMTPS id 8458E385E004 for ; Thu, 26 Mar 2020 09:35:05 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 8458E385E004 Received: by mail-pj1-x1031.google.com with SMTP id z3so1652517pjr.4 for ; Thu, 26 Mar 2020 02:35:05 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=BI1z63jYA11iVwIoEzrJldWg2GHJhsc1EihA3a0Ax9U=; b=UywaT5TZvY2GbBOM0JuAYt+m4AUpNjJ6z13LOD1c5I6tgMSF2rRvWsimy6YQEN0TDm zxqvMvfsTNbBWjHeGLRfspsvZnWul7F9w+DwBVBhaIhGBs+p1iVxSF/y+uO0rRMDAq/k bwVGVeVBNTrPxYc98yPNlvIp1pmCarkrR8tO7kmyjPZ7s9g1+LAjEOGk3TnuiITOqF+u T9TS5Z0ankjurnKTEqtUPHXMvAREhxrMsjKcVJ+9G/Up/VjdXOZ9FzLYHF4z55yw/YP+ Z7VSYjxclhdlmqEcZNsxNnxWcf5BuvkXP7l3IDaicyBkpMoAA1EjR1OQcLRIlfVKyt8y ZWZA== X-Gm-Message-State: ANhLgQ252VXB/pD0C+Uix97/RyM+iy50TAgycaKcQYvNjF6c/amXbmZk h0YI2tfuKvEYlxipitK3nDq5CYsTqmo= X-Google-Smtp-Source: ADFU+vsZ97xO4jIatythzlfXi+ik+APpQ942e2nZ4Vhj2oh3Ogv4qk432K1yD6kejN8gC5Cl0pHVlA== X-Received: by 2002:a17:902:8f8e:: with SMTP id z14mr7444210plo.195.1585215303187; Thu, 26 Mar 2020 02:35:03 -0700 (PDT) Received: from bubble.grove.modra.org (158.106.96.58.static.exetel.com.au. [58.96.106.158]) by smtp.gmail.com with ESMTPSA id t63sm1209063pgc.85.2020.03.26.02.35.02 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 26 Mar 2020 02:35:02 -0700 (PDT) Received: by bubble.grove.modra.org (Postfix, from userid 1000) id D1ED4807E4; Thu, 26 Mar 2020 20:04:58 +1030 (ACDT) Date: Thu, 26 Mar 2020 20:04:58 +1030 From: Alan Modra To: binutils@sourceware.org Subject: Re: i386msdos uninitialised read Message-ID: <20200326093458.GK4583@bubble.grove.modra.org> References: <20200323125833.GT4583@bubble.grove.modra.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200323125833.GT4583@bubble.grove.modra.org> User-Agent: Mutt/1.9.4 (2018-02-28) X-Spam-Status: No, score=-26.3 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, FREEMAIL_FROM, GIT_PATCH_0, GIT_PATCH_1, GIT_PATCH_2, GIT_PATCH_3, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: binutils@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Binutils mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 26 Mar 2020 09:35:06 -0000 Another fix. * i386msdos.c (msdos_object_p): Catch -1 return from bfd_bread. diff --git a/bfd/i386msdos.c b/bfd/i386msdos.c index e9307a7a42..38bb441034 100644 --- a/bfd/i386msdos.c +++ b/bfd/i386msdos.c @@ -50,7 +50,7 @@ msdos_object_p (bfd *abfd) bfd_size_type size; if (bfd_seek (abfd, (file_ptr) 0, SEEK_SET) != 0 - || (size = bfd_bread (&hdr, sizeof (hdr), abfd)) < DOS_HDR_SIZE) + || (size = bfd_bread (&hdr, sizeof (hdr), abfd)) + 1 < DOS_HDR_SIZE + 1) { if (bfd_get_error () != bfd_error_system_call) bfd_set_error (bfd_error_wrong_format); -- Alan Modra Australia Development Lab, IBM