From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wm1-x343.google.com (mail-wm1-x343.google.com [IPv6:2a00:1450:4864:20::343]) by sourceware.org (Postfix) with ESMTPS id AC203385E01B for ; Thu, 26 Mar 2020 15:02:11 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org AC203385E01B Received: by mail-wm1-x343.google.com with SMTP id z5so6805786wml.5 for ; Thu, 26 Mar 2020 08:02:11 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=KdtMDK/RFhLWHl9fq4ziDvyfrQAKPNvY2FoHHMDGokk=; b=qOJgWv78OLmsgJjtONx/ehclorE1+D+u6ybqGqexFq1qhcbb0martDlmjE01ozHotk Jh1COwOTjxwI4sMaa72kCSuTzdoiEqYhs1iwUTdNHG1SibiRTfYfnl9Ixj6s+ekdOJj5 1cZKK/b3GN0diH2jaCmEKzKfDVe/F+C4h3iJg6z5I4XpeElsHgut6jDQ5jshKN3uG25R I5dujZvJyJRTOkg29ELStwS0UgTBPRmTcSptRLiUzJyoUaaTLIafVnjlJGsoEeUJiiDJ 7xwkvkcIfQsLMYBBlmfgChFOsOi/UZkBmV2GPAAZGD+689549QNAClaxClv1ablayGzq ncwg== X-Gm-Message-State: ANhLgQ0poOM1pU9q4hlvpimmBW1WrNLL/gBCGsYWyFLuOc8SKUvYp+NW n11LzOaPcUweYIvzQZqj3M6TsmF8vPg= X-Google-Smtp-Source: ADFU+vt8thflkaMDbM9FwFUpNSwEkzli9NV16gdmH6vwz8J2ktzx0r4qnYMgumbU4nqxsvvRNcmEJw== X-Received: by 2002:a1c:5604:: with SMTP id k4mr338419wmb.57.1585234929556; Thu, 26 Mar 2020 08:02:09 -0700 (PDT) Received: from atlantis.home ([2a03:1b20:3:f011::6d]) by smtp.gmail.com with ESMTPSA id q8sm4143994wrc.8.2020.03.26.08.02.08 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 26 Mar 2020 08:02:08 -0700 (PDT) From: Shahab Vahedi To: binutils@sourceware.org Cc: Shahab Vahedi , Claudiu Zissulescu , Anton Kolesov , Francois Bedard , Anton Kolesov Subject: [PATCH] arc: Add support for ARC HS extra registers in core files Date: Thu, 26 Mar 2020 16:02:03 +0100 Message-Id: <20200326150203.18185-1-shahab.vahedi@gmail.com> X-Mailer: git-send-email 2.26.0 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-BeenThere: binutils@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Binutils mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 26 Mar 2020 15:02:12 -0000 From: Anton Kolesov When a coredump is generated, there are a few registers in ARC HS that are put under a special section, namely ".reg-v2". It is for backward compatibility reasons with older tools that we have decided not to extend the generic ".reg" section. This patch makes it possible to display the information better regarding that section. Compare the output of "readelf" without and with these changes: $ readelf -n core # without the patch ... LINUX 0x0000000c Unknown note type: (0x00000600) description data: 78 08 00 00 2f 6c 64 2d 75 43 6c 69 $ readelf -n core # with the patch ... LINUX 0x0000000c NT_ARC_V2 (ARC HS accumulator/extra registers) description data: 78 08 00 00 2f 6c 64 2d 75 43 6c 69 In another commit (soon to be submitted), GDB will makes use of these changes to parse the extra section and its registers. bfd/ChangeLog 2020-03-26 Anton Kolesov * elf-bfd.h (elfcore_write_arc_v2): Add prototype. * elf.c (elfcore_grok_arc_v2): New function. (elfcore_grok_note): Call the new function to handle the corresponding note. (elfcore_write_arc_v2): New function. (elfcore_write_register_note): Call the new function to handle the corresponding pseudo-sections. binutils/ChangeLog 2020-03-26 Anton Kolesov * readelf.c (get_note_type): Handle NT_ARC_V2. include/elf/ChangeLog 2020-03-26 Anton Kolesov * common.h (NT_ARC_V2): New macro definitions. --- bfd/elf-bfd.h | 2 ++ bfd/elf.c | 27 +++++++++++++++++++++++++++ binutils/readelf.c | 2 ++ include/elf/common.h | 2 ++ 4 files changed, 33 insertions(+) diff --git a/bfd/elf-bfd.h b/bfd/elf-bfd.h index d4ac5152dfe..088bb77dd72 100644 --- a/bfd/elf-bfd.h +++ b/bfd/elf-bfd.h @@ -2730,6 +2730,8 @@ extern char *elfcore_write_aarch_sve (bfd *, char *, int *, const void *, int); extern char *elfcore_write_aarch_pauth (bfd *, char *, int *, const void *, int); +extern char *elfcore_write_arc_v2 + (bfd *, char *, int *, const void *, int); extern char *elfcore_write_lwpstatus (bfd *, char *, int *, long, int, const void *); extern char *elfcore_write_register_note diff --git a/bfd/elf.c b/bfd/elf.c index 8ab7b3e2e81..63da5ce08b8 100644 --- a/bfd/elf.c +++ b/bfd/elf.c @@ -9820,6 +9820,12 @@ elfcore_grok_aarch_pauth (bfd *abfd, Elf_Internal_Note *note) return elfcore_make_note_pseudosection (abfd, ".reg-aarch-pauth", note); } +static bfd_boolean +elfcore_grok_arc_v2 (bfd *abfd, Elf_Internal_Note *note) +{ + return elfcore_make_note_pseudosection (abfd, ".reg-arc-v2", note); +} + #if defined (HAVE_PRPSINFO_T) typedef prpsinfo_t elfcore_psinfo_t; #if defined (HAVE_PRPSINFO32_T) /* Sparc64 cross Sparc32 */ @@ -10379,6 +10385,13 @@ elfcore_grok_note (bfd *abfd, Elf_Internal_Note *note) else return TRUE; + case NT_ARC_V2: + if (note->namesz == 6 + && strcmp (note->namedata, "LINUX") == 0) + return elfcore_grok_arc_v2 (abfd, note); + else + return TRUE; + case NT_ARM_VFP: if (note->namesz == 6 && strcmp (note->namedata, "LINUX") == 0) @@ -11790,6 +11803,18 @@ elfcore_write_aarch_pauth (bfd *abfd, note_name, NT_ARM_PAC_MASK, aarch_pauth, size); } +char * +elfcore_write_arc_v2 (bfd *abfd, + char *buf, + int *bufsiz, + const void *arc_v2, + int size) +{ + char *note_name = "LINUX"; + return elfcore_write_note (abfd, buf, bufsiz, + note_name, NT_ARC_V2, arc_v2, size); +} + char * elfcore_write_register_note (bfd *abfd, char *buf, @@ -11872,6 +11897,8 @@ elfcore_write_register_note (bfd *abfd, return elfcore_write_aarch_sve (abfd, buf, bufsiz, data, size); if (strcmp (section, ".reg-aarch-pauth") == 0) return elfcore_write_aarch_pauth (abfd, buf, bufsiz, data, size); + if (strcmp (section, ".reg-arc-v2") == 0) + return elfcore_write_arc_v2 (abfd, buf, bufsiz, data, size); return NULL; } diff --git a/binutils/readelf.c b/binutils/readelf.c index a11297845e8..15b4f1cc661 100644 --- a/binutils/readelf.c +++ b/binutils/readelf.c @@ -17553,6 +17553,8 @@ get_note_type (Filedata * filedata, unsigned e_type) return _("NT_ARM_HW_BREAK (AArch hardware breakpoint registers)"); case NT_ARM_HW_WATCH: return _("NT_ARM_HW_WATCH (AArch hardware watchpoint registers)"); + case NT_ARC_V2: + return _("NT_ARC_V2 (ARC HS accumulator/extra registers)"); case NT_PSTATUS: return _("NT_PSTATUS (pstatus structure)"); case NT_FPREGS: diff --git a/include/elf/common.h b/include/elf/common.h index 1c84ccb430e..e8447678226 100644 --- a/include/elf/common.h +++ b/include/elf/common.h @@ -652,6 +652,8 @@ /* note name must be "LINUX". */ #define NT_ARM_PAC_MASK 0x406 /* AArch pointer authentication code masks */ /* note name must be "LINUX". */ +#define NT_ARC_V2 0x600 /* ARC HS accumulator/extra registers. */ + /* note name must be "LINUX". */ #define NT_SIGINFO 0x53494749 /* Fields of siginfo_t. */ #define NT_FILE 0x46494c45 /* Description of mapped files. */ -- 2.26.0