From: Alan Modra <amodra@gmail.com>
To: Jozef Lawrynowicz <jozef.l@mittosystems.com>
Cc: "binutils@sourceware.org" <binutils@sourceware.org>
Subject: Re: [PATCH] Add testcase for PR 25662 invalid sh_offset for section
Date: Fri, 27 Mar 2020 07:55:12 +1030 [thread overview]
Message-ID: <20200326212512.GM4583@bubble.grove.modra.org> (raw)
In-Reply-To: <20200326111036.4e8e59d6@jozef-kubuntu>
On Thu, Mar 26, 2020 at 11:10:36AM +0000, Jozef Lawrynowicz wrote:
> The attached patch has a testcase for PR binutils/25662, "objcopy sets invalid
> sh_offset for the first section in a no_contents segment containing program
> headers".
>
> The patch also extends the objcopy_test procedure from objcopy.exp, allowing
> either object files or linked executables to be tested.
>
> I verified that the testcase does not error for msp430-elf,
> x86_64-pc-linux-gnu, arm-eabi, ia64-vms (has no linker so the test is
> untested) and i386-pe (is not an ELF target).
>
> Note that the test fails for i386-pe, objdump -x output shows that the
> "Time/Date" field has been reset to epoch 0.
>
> Ok to apply?
OK, thanks. Yes, we are going to have some fails with this new test.
Hmm, objcopy -p doesn't help with the PE date stamp and it seems like
it should.
You might like to simplify the LD test.
> + set status [remote_exec host $LD -v]
> + if { [lindex $status 0] != 0 } {
if {[which $LD] == 0} then {
> + untested "objcopy $type ($testname)"
> + return
> + }
--
Alan Modra
Australia Development Lab, IBM
next prev parent reply other threads:[~2020-03-26 21:25 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-26 11:10 Jozef Lawrynowicz
2020-03-26 21:25 ` Alan Modra [this message]
2020-03-27 10:59 ` Jozef Lawrynowicz
2020-03-27 21:03 ` Hans-Peter Nilsson
2020-03-28 0:52 ` Alan Modra
2020-03-28 2:01 ` Hans-Peter Nilsson
2020-03-28 6:15 ` Alan Modra
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200326212512.GM4583@bubble.grove.modra.org \
--to=amodra@gmail.com \
--cc=binutils@sourceware.org \
--cc=jozef.l@mittosystems.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).