public inbox for binutils@sourceware.org
 help / color / mirror / Atom feed
From: Alan Modra <amodra@gmail.com>
To: Nick Clifton <nickc@redhat.com>
Cc: Jozef Lawrynowicz <jozef.l@mittosystems.com>, binutils@sourceware.org
Subject: Re: PR 25562: New binutils testsuite failures
Date: Mon, 30 Mar 2020 23:15:41 +1030	[thread overview]
Message-ID: <20200330124541.GX4583@bubble.grove.modra.org> (raw)
In-Reply-To: <f060928f-16bf-5b09-eb85-7602eff44d44@redhat.com>

On Mon, Mar 30, 2020 at 01:26:53PM +0100, Nick Clifton via Binutils wrote:
> Hi Jozef,
> 
> > The test is working as expected, for those targets an objcopy of an executable
> > is not creating an exact copy of the original file.
> 
> Ah, OK.
> 
> > For the PE targets the datestamp in the executable file is not being copied by
> > objcopy.
> 
> The old determinism problem.  *sigh*  We should probably just xfail these
> targets since we know that the binaries can never be the same.

Except that objcopy -p ought to preserve the time, shouldn't it?

> > For the MIPS targets, objcopy has added the names of output sections to the
> > string table, where in the linked executable they were not in the string table.
> 
> Where were the names stored then, if not in the string table ?  Or did the
> objcopy actually add new section symbols ?

ELF section symbols normally have 0 in st_name, with an implicit name
taken from their section.  MIPS for backwards compatibility with other
linkers gives them a string table entry.  objcopy decided the copy
needed that backward compat, while ld decided the original didn't.

> 
> This does sound like something that the MIPS maintainers ought to investigate
> and decide whether it is a real bug or not.
> 
> > I can file bugzillas for these if you would like.
> 
> No, that should not be necessary.  I will check in an update for the PE targets
> once I have tested it locally.
> 
> Cheers
>   Nick
> 

-- 
Alan Modra
Australia Development Lab, IBM

  parent reply	other threads:[~2020-03-30 12:45 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-03-30  9:48 Nick Clifton
2020-03-30 12:15 ` Jozef Lawrynowicz
2020-03-30 12:26   ` Nick Clifton
2020-03-30 12:36     ` Jozef Lawrynowicz
2020-03-30 12:45     ` Alan Modra [this message]
2020-03-30 14:00       ` Nick Clifton
2020-03-30 15:29       ` Nick Clifton
2020-03-31  0:18       ` Maciej W. Rozycki
2020-08-02 12:53         ` Maciej W. Rozycki

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200330124541.GX4583@bubble.grove.modra.org \
    --to=amodra@gmail.com \
    --cc=binutils@sourceware.org \
    --cc=jozef.l@mittosystems.com \
    --cc=nickc@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).