From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pl1-x62c.google.com (mail-pl1-x62c.google.com [IPv6:2607:f8b0:4864:20::62c]) by sourceware.org (Postfix) with ESMTPS id 12A6B385B835 for ; Tue, 31 Mar 2020 06:26:30 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 12A6B385B835 Received: by mail-pl1-x62c.google.com with SMTP id k18so2936875pll.6 for ; Mon, 30 Mar 2020 23:26:30 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:subject:message-id:mime-version :content-disposition:user-agent; bh=87Ep4hgdB8HoIkLaU23TFWYpQwrI1dLXjerR4uYXLYw=; b=E/0f9k0A44Zc37+onMfaW7rjdTIxgTuqSiuo0UBcAFbnW+CzR4eZ+uJ+sFRkBpuMyS teWvg9nsXM85tgN7b5Wi2NC8qRnU4Qplu+rU2Lei3F0qSUFVM2+MN9gM965sOhdkydm4 AzkH2KJevr0kypg27W8HPa6RJI2gGBH219GjyvRYu5Enc2143rRuVlvazV7pOppXx2zI 2vNosReG+CSM2fvd7gerV0lp6yPHD5EtvR6aMr/ywlMU2j4H2zzS3hAwboqT0LggcW/Z wSOvkWBsazwAU3U1iPSwHOeksvBZ0ia3sfMmPgHFl75LnAApvrGqr34S8P6AQS3+QQ2x RiCg== X-Gm-Message-State: ANhLgQ15cIg2hbDQC3Zd+be3w22lJKI1CvXLgTY7OVXX/NCoFasAJbdr RR4oBUYEFHL8MNRFPh7iZefhekloXws= X-Google-Smtp-Source: ADFU+vvCXMwFjeYJUymFvQIPTj56kRaTpoNLS4qUK8nHepMp91STD0dfd8Rf0nMrNJEiicSICWmQOw== X-Received: by 2002:a17:902:7283:: with SMTP id d3mr15583996pll.65.1585635988892; Mon, 30 Mar 2020 23:26:28 -0700 (PDT) Received: from bubble.grove.modra.org (158.106.96.58.static.exetel.com.au. [58.96.106.158]) by smtp.gmail.com with ESMTPSA id l9sm1047853pjl.20.2020.03.30.23.26.27 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 30 Mar 2020 23:26:27 -0700 (PDT) Received: by bubble.grove.modra.org (Postfix, from userid 1000) id A79A488E01; Tue, 31 Mar 2020 16:56:23 +1030 (ACDT) Date: Tue, 31 Mar 2020 16:56:23 +1030 From: Alan Modra To: binutils@sourceware.org Subject: tekhex: Uninitialised read Message-ID: <20200331062623.GY4583@bubble.grove.modra.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline User-Agent: Mutt/1.9.4 (2018-02-28) X-Spam-Status: No, score=-26.3 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, FREEMAIL_FROM, GIT_PATCH_0, GIT_PATCH_1, GIT_PATCH_2, GIT_PATCH_3, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: binutils@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Binutils mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 31 Mar 2020 06:26:31 -0000 * tekhex.c (pass_over): Check is_eof before reading buffer. diff --git a/bfd/tekhex.c b/bfd/tekhex.c index c2834b32d0..0001457c74 100644 --- a/bfd/tekhex.c +++ b/bfd/tekhex.c @@ -525,7 +525,7 @@ pass_over (bfd *abfd, bfd_boolean (*func) (bfd *, int, char *, char *)) /* Find first '%'. */ is_eof = (bfd_boolean) (bfd_bread (src, (bfd_size_type) 1, abfd) != 1); - while (*src != '%' && !is_eof) + while (!is_eof && *src != '%') is_eof = (bfd_boolean) (bfd_bread (src, (bfd_size_type) 1, abfd) != 1); if (is_eof) -- Alan Modra Australia Development Lab, IBM