From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pl1-x632.google.com (mail-pl1-x632.google.com [IPv6:2607:f8b0:4864:20::632]) by sourceware.org (Postfix) with ESMTPS id 393A7385B835 for ; Tue, 31 Mar 2020 06:27:46 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 393A7385B835 Received: by mail-pl1-x632.google.com with SMTP id k18so2938099pll.6 for ; Mon, 30 Mar 2020 23:27:46 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:subject:message-id:mime-version :content-disposition:user-agent; bh=HlOTlvWRfMuDznhst+lKraFPQFwSCLryKwWpZ52Y8lY=; b=hiM7nPIOejfNv1y+jz+56I5CbaMQXJqAxT5MV7+7h4WH/E++Ek2iD5c5SNzd/vEltd FMEcagemGOiSDuR87B/H++0GvaREoCmgfQ8l7J0Uy7lsdhNrvHn8y6KOf4Aq0UxjqBid f0saefyR3ZriCyGEPzn8AYcaj6XeG9pm/wbeTXHV/vhGIHQn6StTj1CkcDL2KUNuIocN 7rlVEeDzDdoWE3OIY2uOsvatlgUAhm5EfM32MrJ2JEloIeaV0sVH42MLfduu7fjy5kgN kdkvIXPC/Vj1o+IYJBqMRzshhbtOhspsLFFYojlosWYcNO3VRxhQqmLuin5x8QO1KJR4 VMfw== X-Gm-Message-State: ANhLgQ1oCxGcsaxV4CWr2zXr39VVP/uYK9/Nf7cMF0cSa+zSsn1tBmcn Y0I5UX4K8rYAsDM/3ekNUagoFUQdHcc= X-Google-Smtp-Source: ADFU+vtXgDzttf6gVVM+6RhzRnbGKEGsniSHpAEtU39ocXhbLMGOmg1nXI3BazIy8201NCLlBFYUDg== X-Received: by 2002:a17:902:be14:: with SMTP id r20mr16320448pls.270.1585636065084; Mon, 30 Mar 2020 23:27:45 -0700 (PDT) Received: from bubble.grove.modra.org (158.106.96.58.static.exetel.com.au. [58.96.106.158]) by smtp.gmail.com with ESMTPSA id q6sm1038969pja.34.2020.03.30.23.27.43 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 30 Mar 2020 23:27:44 -0700 (PDT) Received: by bubble.grove.modra.org (Postfix, from userid 1000) id 3777888E01; Tue, 31 Mar 2020 16:57:41 +1030 (ACDT) Date: Tue, 31 Mar 2020 16:57:41 +1030 From: Alan Modra To: binutils@sourceware.org Subject: alpha-coff: unitialised read Message-ID: <20200331062741.GA4583@bubble.grove.modra.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline User-Agent: Mutt/1.9.4 (2018-02-28) X-Spam-Status: No, score=-26.3 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, FREEMAIL_FROM, GIT_PATCH_0, GIT_PATCH_1, GIT_PATCH_2, GIT_PATCH_3, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: binutils@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Binutils mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 31 Mar 2020 06:27:47 -0000 * coff-alpha.c (alpha_ecoff_get_elt_at_filepos): Correct bfd_bread return value check. diff --git a/bfd/coff-alpha.c b/bfd/coff-alpha.c index b86a8a259b..4fd3b5c488 100644 --- a/bfd/coff-alpha.c +++ b/bfd/coff-alpha.c @@ -2130,7 +2130,7 @@ alpha_ecoff_get_elt_at_filepos (bfd *archive, file_ptr filepos) n = dict[h]; else { - if (! bfd_bread (&n, (bfd_size_type) 1, nbfd)) + if (bfd_bread (&n, 1, nbfd) != 1) goto error_return; dict[h] = n; } -- Alan Modra Australia Development Lab, IBM