From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pg1-x541.google.com (mail-pg1-x541.google.com [IPv6:2607:f8b0:4864:20::541]) by sourceware.org (Postfix) with ESMTPS id 666E4385B833 for ; Fri, 3 Apr 2020 05:15:37 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 666E4385B833 Received: by mail-pg1-x541.google.com with SMTP id k191so2944399pgc.13 for ; Thu, 02 Apr 2020 22:15:37 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=hMOMLx/zZmf1BwWZg2BENIXC2mDRNAO8dWiIuH5+bA0=; b=cakRHrwSJjbads3HLkKJIC1mkpvSluZ6OBr8dVCq0rL17U95HUy4vv5jssTPu3BnzE OizJFvYVBFoUHPscr6aYkU8uKsA1hOd8BDZRb7Y7Y+kmmDvjwN3rtky6S7JhhJ/PjEnK AQSwDaUO9i8g4FpRYhpyfJQyVxpnT99a4vRDhQG8TjwNNEttfmjKoSFocQo+WzM4rfrW SjsaXDodtEJyiqnG/a3P/g/zD2gjWSJpv0YwIpzXjHqLD92T60WlC49tGx6O8s54c1u0 TKXFnmi+ET1JJKe8Wi4QldwG8CyeC7xc0NqyTgEXvSB5a8tLt2Ij6rRcRcb7J3Mcdcy9 OXPw== X-Gm-Message-State: AGi0PuazQhDqzRX/+2Slt0bqdWaP48qsaKwvpVkxuMJekDIcYuHQrU0a OQHYIKC+Of7JCPCSogsglas= X-Google-Smtp-Source: APiQypKmsdUXcS3r0HjJP6+YtWlw2i8AfotxZqQLTVud0tkAjb+KrvMEnyIacZ5/o5lyhamFckZRCQ== X-Received: by 2002:a62:1c08:: with SMTP id c8mr7037958pfc.80.1585890936568; Thu, 02 Apr 2020 22:15:36 -0700 (PDT) Received: from bubble.grove.modra.org (158.106.96.58.static.exetel.com.au. [58.96.106.158]) by smtp.gmail.com with ESMTPSA id j96sm4806934pje.32.2020.04.02.22.15.35 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 02 Apr 2020 22:15:35 -0700 (PDT) Received: by bubble.grove.modra.org (Postfix, from userid 1000) id 15F3988DB1; Fri, 3 Apr 2020 15:45:32 +1030 (ACDT) Date: Fri, 3 Apr 2020 15:45:32 +1030 From: Alan Modra To: Fangrui Song Cc: binutils@sourceware.org Subject: Re: [PATCH] Set the sh_entsize field of .stab to 12 Message-ID: <20200403051531.GG4583@bubble.grove.modra.org> References: <20200403045843.164144-1-maskray@google.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200403045843.164144-1-maskray@google.com> User-Agent: Mutt/1.9.4 (2018-02-28) X-Spam-Status: No, score=-25.4 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, FREEMAIL_FROM, GIT_PATCH_0, GIT_PATCH_1, GIT_PATCH_2, GIT_PATCH_3, KAM_NUMSUBJECT, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: binutils@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Binutils mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 03 Apr 2020 05:15:39 -0000 On Thu, Apr 02, 2020 at 09:58:43PM -0700, Fangrui Song via Binutils wrote: > --- > bfd/ChangeLog | 4 ++++ > bfd/elf.c | 4 +--- > 2 files changed, 5 insertions(+), 3 deletions(-) > > diff --git a/bfd/ChangeLog b/bfd/ChangeLog > index 64c3dde475..90e19b8612 100644 > --- a/bfd/ChangeLog > +++ b/bfd/ChangeLog > @@ -1,3 +1,7 @@ > +2020-04-02 Fangrui Song > + > + * elf.c (assign_section_numbers): Set .stab sh_entsize to 12. > + > 2020-04-02 Jan W. Jagersma OK. Please justify the patch when posting and in the git log. "Only 32-bit stabs are supported" would do. > * bfdio.c (bfd_bread, bfd_tell, bfd_seek, bfd_mmap): Always add > diff --git a/bfd/elf.c b/bfd/elf.c > index 86dadea05c..0c550bdadf 100644 > --- a/bfd/elf.c > +++ b/bfd/elf.c > @@ -3998,9 +3998,7 @@ assign_section_numbers (bfd *abfd, struct bfd_link_info *link_info) > elf_section_data (s)->this_hdr.sh_link = d->this_idx; > > /* This is a .stab section. */ > - if (elf_section_data (s)->this_hdr.sh_entsize == 0) > - elf_section_data (s)->this_hdr.sh_entsize > - = 4 + 2 * bfd_get_arch_size (abfd) / 8; > + elf_section_data (s)->this_hdr.sh_entsize = 12; > } > } > break; > -- > 2.26.0.292.g33ef6b2f38-goog -- Alan Modra Australia Development Lab, IBM