From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <36NGGXgcKCKENBTLSBZHPPHMF.DPNCJOVUJMTTPVSDFXBSF.PSH@flex--maskray.bounces.google.com> Received: from mail-pg1-x549.google.com (mail-pg1-x549.google.com [IPv6:2607:f8b0:4864:20::549]) by sourceware.org (Postfix) with ESMTPS id B870D385B833 for ; Fri, 3 Apr 2020 06:04:25 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org B870D385B833 Received: by mail-pg1-x549.google.com with SMTP id w70so52377pgw.6 for ; Thu, 02 Apr 2020 23:04:25 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:in-reply-to:message-id:mime-version :references:subject:from:to:cc; bh=6sRdUqdQUTXwVJ/7G62UEbLcDZSXt/15QIpBAKBrzp8=; b=Sf0K/A3R5W4ZCpvtMmaszLw5TWzTcGHMfWFzydK/59yvD8LgkzoQeuSBskcp2KtCSf hw3mpwO4zxb9RVpt5WDTSHEw3Jxu1h4QNotZYYHefEX9F+BiS/XFu/WCgJr0Q7MKQoGC BqWFIvDAJdzE+nhybKgnQDZBeSoAzfYY7oPIt8p8tl1uz6g2LtEt9xJKefm9dmqMblSY 1U5yzBl2VS9tunwxUZrsmAoh//B+l5w3RT3mA/ojcBJUQNPMG+DvK+dbRnCO5UiDHF8K jwE10RDAYWMdwiEOvYQe3szlba7LgtgBz6nQosmKnvqHdhMxoQJXDvwcoL+awet/Lw5W 5baA== X-Gm-Message-State: AGi0PuZtKCIy5xvqvBauWyZGHfszrrz7gdjWpuEu1Sg0ef+h/gTEkUAp eN9grzds6v22sdAtcekuarZ9j0x0R2Amv01HRU8BUyJWUqhuGrue5paffkBe36b2BC+FrMHMIGH NE1lHh4Mdrnlolpz1bczsknXMtebAeF3V2ZIEmORY31RJsfwM+p16PnLK4RXFIlLCgA== X-Google-Smtp-Source: APiQypIJSEnLsVVp4mkt3hfVm89sb9faqzlJppEYweKhyyjo6RgiIUu3+9BTxji1epHC3OuIX4fEvv7Vt6s2 X-Received: by 2002:a17:90b:24c:: with SMTP id fz12mr7630291pjb.85.1585893864583; Thu, 02 Apr 2020 23:04:24 -0700 (PDT) Date: Thu, 2 Apr 2020 23:03:47 -0700 In-Reply-To: <20200403051531.GG4583@bubble.grove.modra.org> Message-Id: <20200403060346.237913-1-maskray@google.com> Mime-Version: 1.0 References: <20200403051531.GG4583@bubble.grove.modra.org> X-Mailer: git-send-email 2.26.0.292.g33ef6b2f38-goog Subject: [PATCH v2] Set the sh_entsize field of .stab to 12 From: Fangrui Song To: binutils@sourceware.org Cc: Fangrui Song Content-Type: text/plain; charset="UTF-8" X-Spam-Status: No, score=-31.9 required=5.0 tests=BAYES_00, DKIMWL_WL_MED, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, GIT_PATCH_0, GIT_PATCH_1, GIT_PATCH_2, GIT_PATCH_3, KAM_NUMSUBJECT, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP, USER_IN_DEF_DKIM_WL autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: binutils@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Binutils mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 03 Apr 2020 06:04:27 -0000 The existing code assumes sh_entsize(.stab)=20 on ELFCLASS64. However, the assembler only supports 32-bit stabs. So set sh_entsize unconditionally to 12. PR gas/25768 * elf.c (assign_section_numbers): Set .stab sh_entsize to 12. --- bfd/ChangeLog | 5 +++++ bfd/elf.c | 4 +--- 2 files changed, 6 insertions(+), 3 deletions(-) diff --git a/bfd/ChangeLog b/bfd/ChangeLog index 64c3dde475..47b8e566ef 100644 --- a/bfd/ChangeLog +++ b/bfd/ChangeLog @@ -1,3 +1,8 @@ +2020-04-02 Fangrui Song + + PR gas/25768 + * elf.c (assign_section_numbers): Set .stab sh_entsize to 12. + 2020-04-02 Jan W. Jagersma * bfdio.c (bfd_bread, bfd_tell, bfd_seek, bfd_mmap): Always add diff --git a/bfd/elf.c b/bfd/elf.c index 86dadea05c..0c550bdadf 100644 --- a/bfd/elf.c +++ b/bfd/elf.c @@ -3998,9 +3998,7 @@ assign_section_numbers (bfd *abfd, struct bfd_link_info *link_info) elf_section_data (s)->this_hdr.sh_link = d->this_idx; /* This is a .stab section. */ - if (elf_section_data (s)->this_hdr.sh_entsize == 0) - elf_section_data (s)->this_hdr.sh_entsize - = 4 + 2 * bfd_get_arch_size (abfd) / 8; + elf_section_data (s)->this_hdr.sh_entsize = 12; } } break; -- 2.26.0.292.g33ef6b2f38-goog