From: Gunther Nikl <gnikl@justmail.de>
To: Nick Clifton <nickc@redhat.com>
Cc: binutils <binutils@sourceware.org>
Subject: Re: [PATCH 4/4]: Add generic prototype for md_pcrel_from_section
Date: Thu, 9 Apr 2020 21:29:54 +0200 [thread overview]
Message-ID: <20200409212954.00006a33@justmail.de> (raw)
In-Reply-To: <da3a7c86-58b9-b19e-419d-2ceabfe63d8c@redhat.com>
Nick Clifton <nickc@redhat.com> wrote:
> Hi Gunther,
>
> > This patch removes the need for target headers to provide a custom
> > prototype for md_pcrel_from_section.
>
> Approved and applied.
Thank you for taking care of the patch series. Sorry I botched the
submission. I only realized after sending the mails that I should have
sent the patches as a reply of the introduction mail :-/
> > The following ports use the same interface version but with the
> > port name as a function prefix:
> >
> > - ia64: ia64_pcrel_from_section
> > - nds32: nds32_pcrel_from_section
> > - tic6x: tic6x_pcrel_from_section
> > - v850: v850_pcrel_from_section
> > - visium: visium_pcrel_from_section
>
> I do not think that there is any need for this. Using target specific
> names helps to emphasise that the functions have target specific
> actions.
FWIW, I agree. I just mentioned it to make it visible.
Regards,
Gunther
next prev parent reply other threads:[~2020-04-09 19:33 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-07 10:02 Gunther Nikl
2020-04-08 11:29 ` Nick Clifton
2020-04-09 19:29 ` Gunther Nikl [this message]
-- strict thread matches above, loose matches on Subject: below --
2020-04-07 10:01 [PATCH 0/4]: gas: cleanup for MD_PCREL_FROM_SECTION Gunther Nikl
2020-04-07 11:15 ` [PATCH 4/4]: Add generic prototype for md_pcrel_from_section Gunther Nikl
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200409212954.00006a33@justmail.de \
--to=gnikl@justmail.de \
--cc=binutils@sourceware.org \
--cc=nickc@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).