From: Alan Modra <amodra@gmail.com>
To: binutils@sourceware.org
Subject: asan: ns32k: use of uninitialized value
Date: Thu, 28 May 2020 21:10:31 +0930 [thread overview]
Message-ID: <20200528114031.GC5475@bubble.grove.modra.org> (raw)
Nick, I had this one fixed, likely before you got out of bed this
morning, but not pushed upstream.
* ns32k-dis.c (print_insn_arg): Handle d value of 'f' for
immediates.
(print_insn_ns32k): Revert last change.
diff --git a/opcodes/ns32k-dis.c b/opcodes/ns32k-dis.c
index ccad820d8f..eac461a969 100644
--- a/opcodes/ns32k-dis.c
+++ b/opcodes/ns32k-dis.c
@@ -524,9 +524,7 @@ print_insn_arg (int d,
/* Immediate. */
switch (d)
{
- case 'I':
- case 'Z':
- case 'A':
+ default:
/* I and Z are output operands and can`t be immediate
A is an address and we can`t have the address of
an immediate either. We don't know how much to increase
@@ -738,10 +736,7 @@ print_insn_ns32k (bfd_vma memaddr, disassemble_info *info)
unsigned short first_word;
int ioffset; /* Bits into instruction. */
int aoffset; /* Bits into arguments. */
- /* The arg_bufs array is made static in order to avoid a potential
- use of an uninitialised value if we are asekd to disassemble a
- corrupt instruction. */
- static char arg_bufs[MAX_ARGS+1][ARG_LEN];
+ char arg_bufs[MAX_ARGS+1][ARG_LEN];
int argnum;
int maxarg;
struct private priv;
--
Alan Modra
Australia Development Lab, IBM
reply other threads:[~2020-05-28 11:40 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200528114031.GC5475@bubble.grove.modra.org \
--to=amodra@gmail.com \
--cc=binutils@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).