[PATCH] nios2: Don't check relocations in non-loaded, non-alloced sections

[PATCH] nios2: Don't check relocations in non-loaded, non-alloced sections

[H.J. Lu]

Don't do anything special with non-loaded, non-alloced sections.
In particular, any relocs in such sections should not affect GOT
and PLT reference counting (ie. we don't allow them to create GOT
or PLT entries), there's no possibility or desire to optimize TLS
relocs, and there's not much point in propagating relocs to shared
libs that the dynamic linker won't relocate.

This fixed:

FAIL: Common symbol override test

OK for master?

H.J.
---
	PR ld/26066
	* elf32-nios2.c (nios2_elf32_check_relocs): Skip non-loaded,
	non-alloced sections.
---
 bfd/elf32-nios2.c | 9 +++++++++
 1 file changed, 9 insertions(+)

diff --git a/bfd/elf32-nios2.c b/bfd/elf32-nios2.c
index 0b2e68ebd6..f0cdd5203a 100644
--- a/bfd/elf32-nios2.c
+++ b/bfd/elf32-nios2.c
@@ -4724,6 +4724,15 @@ nios2_elf32_check_relocs (bfd *abfd, struct bfd_link_info *info,
   if (bfd_link_relocatable (info))
     return TRUE;
 
+  /* Don't do anything special with non-loaded, non-alloced sections.
+     In particular, any relocs in such sections should not affect GOT
+     and PLT reference counting (ie. we don't allow them to create GOT
+     or PLT entries), there's no possibility or desire to optimize TLS
+     relocs, and there's not much point in propagating relocs to shared
+     libs that the dynamic linker won't relocate.  */
+  if ((sec->flags & SEC_ALLOC) == 0)
+    return TRUE;
+
   symtab_hdr = &elf_tdata (abfd)->symtab_hdr;
   sym_hashes = elf_sym_hashes (abfd);
   sym_hashes_end = (sym_hashes
-- 
2.26.2

Re: [PATCH] nios2: Don't check relocations in non-loaded, non-alloced sections

[Nick Clifton]

Hi H.J.

> 	PR ld/26066
> 	* elf32-nios2.c (nios2_elf32_check_relocs): Skip non-loaded,
> 	non-alloced sections.
 
Approved - please apply.

Cheers
  Nick