From: Alan Modra <amodra@gmail.com>
To: Alex Coplan <alex.coplan@arm.com>
Cc: binutils@sourceware.org, ramana.radhakrishnan@arm.com,
nd@arm.com, rearnsha@arm.com, marcus.shawcroft@arm.com
Subject: Re: [PATCH] gas: Fix checking for backwards .org with negative offset
Date: Mon, 1 Jun 2020 08:22:03 +0930 [thread overview]
Message-ID: <20200531225203.GJ5475@bubble.grove.modra.org> (raw)
In-Reply-To: <20200529150449.nhukb7pjbyo2cjf5@arm.com>
On Fri, May 29, 2020 at 04:04:50PM +0100, Alex Coplan wrote:
> * testsuite/gas/aarch64/org-neg.d: New test.
> * testsuite/gas/aarch64/org-neg.l: Error output for test.
> * testsuite/gas/aarch64/org-neg.s: Input for test.
> * testsuite/gas/arm/org-neg.d: New test.
> * testsuite/gas/arm/org-neg.l: Error output for test.
> * testsuite/gas/arm/org-neg.s: Input for test.
> * write.c (relax_segment): Fix handling of negative offset when
> relaxing an rs_org frag.
This is OK everywhere with the formatting fixed.
> - if (address + fragP->fr_fix > target)
> + if ((offsetT)(address + fragP->fr_fix) > target)
if ((offsetT) (address + fragP->fr_fix) > target)
--
Alan Modra
Australia Development Lab, IBM
next prev parent reply other threads:[~2020-05-31 22:52 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-29 15:04 Alex Coplan
2020-05-31 22:52 ` Alan Modra [this message]
2020-06-01 8:06 ` Alex Coplan
2020-06-09 14:06 ` Alex Coplan
2020-06-10 5:59 ` Alan Modra
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200531225203.GJ5475@bubble.grove.modra.org \
--to=amodra@gmail.com \
--cc=alex.coplan@arm.com \
--cc=binutils@sourceware.org \
--cc=marcus.shawcroft@arm.com \
--cc=nd@arm.com \
--cc=ramana.radhakrishnan@arm.com \
--cc=rearnsha@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).