From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pl1-x641.google.com (mail-pl1-x641.google.com [IPv6:2607:f8b0:4864:20::641]) by sourceware.org (Postfix) with ESMTPS id 3131C3851C2F for ; Mon, 1 Jun 2020 07:20:05 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 3131C3851C2F Received: by mail-pl1-x641.google.com with SMTP id g12so232372pll.10 for ; Mon, 01 Jun 2020 00:20:05 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=zzUJmaDShQuFfiCt8ZCR97HSGyvwb1sgHrTJRzLMs6Y=; b=Cv1eE0AAFOtHJWyBhf3nWzNsb4T6p28uCg/2PozrOB2ga7RvQYSrE4D/H/ZNEhhFxV v9nGI8kV6PYheA2aDxmOBr3epWeXR2uwOwtcbJk57gZ+Z+IQSD72mN3d0LCOaATpZUoG EKFv+JX68niV1j8JFkcSQUYCNtGEe8cFNDPL+6bjj2KZYwAaA/kzH4atEo+UWb7BVsun og6Jd/bo5ZxhxlSSoRFKf1PKl6jKmijdFRyg97wwNjB0iE5jL91/yLLu3Y+/PqdxqgDx Otz8XuGUjzP1YP6wDnc33lKZKtXeRgo5enqOo3jItnUaJ7keqy6ZlIYXetJHxY6hsoAS Vacg== X-Gm-Message-State: AOAM532SaYx/lmLNOk+vtgT7jCEuTPv20yRvsMERzAR/R0x9jbwLTH1P lI4vUMnGHUKBkT1xL02iYeU= X-Google-Smtp-Source: ABdhPJyMChKGNniq0tbu2moiMBX2kyaBrhqG22+LPXHLfIySp0LBnIMdpgADINEi88BI7F72G5sufg== X-Received: by 2002:a17:902:aa0a:: with SMTP id be10mr4335617plb.263.1590996004292; Mon, 01 Jun 2020 00:20:04 -0700 (PDT) Received: from bubble.grove.modra.org (158.106.96.58.static.exetel.com.au. [58.96.106.158]) by smtp.gmail.com with ESMTPSA id 128sm13167812pfd.114.2020.06.01.00.20.02 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 01 Jun 2020 00:20:03 -0700 (PDT) Received: by bubble.grove.modra.org (Postfix, from userid 1000) id 66B83889AD; Mon, 1 Jun 2020 16:49:59 +0930 (ACST) Date: Mon, 1 Jun 2020 16:49:59 +0930 From: Alan Modra To: "Jose E. Marchesi" Cc: binutils@sourceware.org Subject: Re: [PATCH 1/3] opcodes: support insn endianness in cgen_cpu_open Message-ID: <20200601071959.GK5475@bubble.grove.modra.org> References: <20200529170820.3875-1-jose.marchesi@oracle.com> <20200529170820.3875-2-jose.marchesi@oracle.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200529170820.3875-2-jose.marchesi@oracle.com> User-Agent: Mutt/1.9.4 (2018-02-28) X-Spam-Status: No, score=-8.1 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, FREEMAIL_FROM, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: binutils@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Binutils mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 01 Jun 2020 07:20:06 -0000 On Fri, May 29, 2020 at 07:08:18PM +0200, Jose E. Marchesi via Binutils wrote: > include/ChangeLog: > > 2020-05-29 Jose E. Marchesi > > * opcode/cgen.h (enum cgen_cpu_open_arg): New value > CGEN_CPU_OPEN_INSN_ENDIAN. > > opcodes/ChangeLog: > > 2020-05-29 Jose E. Marchesi > > * cgen-dis.in (cpu_desc_list): New field `insn_endian'. > (print_insn_): Handle instruction endian. > * bpf-dis.c: Regenerate. > * bpf-desc.c: Regenerate. > * epiphany-dis.c: Likewise. > * epiphany-desc.c: Likewise. > * fr30-dis.c: Likewise. > * fr30-desc.c: Likewise. > * frv-dis.c: Likewise. > * frv-desc.c: Likewise. > * ip2k-dis.c: Likewise. > * ip2k-desc.c: Likewise. > * iq2000-dis.c: Likewise. > * iq2000-desc.c: Likewise. > * lm32-dis.c: Likewise. > * lm32-desc.c: Likewise. > * m32c-dis.c: Likewise. > * m32c-desc.c: Likewise. > * m32r-dis.c: Likewise. > * m32r-desc.c: Likewise. > * mep-dis.c: Likewise. > * mep-desc.c: Likewise. > * mt-dis.c: Likewise. > * mt-desc.c: Likewise. > * or1k-dis.c: Likewise. > * or1k-desc.c: Likewise. > * xc16x-dis.c: Likewise. > * xc16x-desc.c: Likewise. > * xstormy16-dis.c: Likewise. > * xstormy16-desc.c: Likewise. > > binutils/ChangeLog: > > 2020-05-29 Jose E. Marchesi > > * objdump.c (disassemble_data): Set disasm_info.endian_code to > disasm_info.endian after the later is initialized to the > endianness reported by BFD. OK, except s/later/latter/ above, and.. > @@ -2269,10 +2271,18 @@ epiphany_cgen_cpu_close (CGEN_CPU_DESC cd) > regfree (CGEN_INSN_RX (insns)); > } > > - free ((CGEN_INSN *) cd->macro_insn_table.init_entries); > - free ((CGEN_INSN *) cd->insn_table.init_entries); > - free ((CGEN_HW_ENTRY *) cd->hw_table.entries); > - free ((CGEN_HW_ENTRY *) cd->operand_table.entries); > + if (cd->macro_insn_table.init_entries) > + free ((CGEN_INSN *) cd->macro_insn_table.init_entries); > + > + if (cd->insn_table.init_entries) > + free ((CGEN_INSN *) cd->insn_table.init_entries); > + > + if (cd->hw_table.entries) > + free ((CGEN_HW_ENTRY *) cd->hw_table.entries); > + > + if (cd->operand_table.entries) > + free ((CGEN_HW_ENTRY *) cd->operand_table.entries); > + > free (cd); > } > Please ensure your copy of cgen is up to date before regenerating. -- Alan Modra Australia Development Lab, IBM