From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pl1-x630.google.com (mail-pl1-x630.google.com [IPv6:2607:f8b0:4864:20::630]) by sourceware.org (Postfix) with ESMTPS id DAC7A388B022 for ; Sun, 21 Jun 2020 12:49:56 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org DAC7A388B022 Received: by mail-pl1-x630.google.com with SMTP id bh7so6272795plb.11 for ; Sun, 21 Jun 2020 05:49:56 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=Xmg0Zz+O5amGqTvAWzuZrGir34rVcvB+Zqolifp5Tzk=; b=L3X4LAb1m90LHUypPpZnvgcGhIamasgLiIWf8U03ZJL/GYTKuFJAkC9wDpq286Xog/ 5SVz2kc8jUVJUFS4Nn3wPkIxwrZxedKlb4jCFper9ZKyDl+wbLgRJZbvWQDKdT3YBgNE MGjIMTPEDKl7B3+R/7tX5UcnW5Ir0TLqN946ErrOIsCRZjqVEK8rUcQ8CYDJ1/XpBA0I aOWpH7Pg8CuLS0sr+Zw3nMdag6KQLYpsBTlbSg9N+o0lOkgDIs8wQzsk+kWW6T33TMqU LsENAAZKDgQMxxk2fJRMaJOxISDRoOY7HEQfalhvnHpKwSYPuBpL/OgD4aEGujfpESIY swPg== X-Gm-Message-State: AOAM533xUVZmRdjR8+RNBFVzFoE9wZLEZ0Ub4ROlOM0BR3/FB+TxGSmP /YBRlPW1+46f2LQ24JAeKp37qkXHKR8= X-Google-Smtp-Source: ABdhPJyBchhaLO0M9IEK7hblWksUzg/Ei+OCUI4CFV4b8F/wvCKDmJwaT901+TV/o+uvapRH0bFeiw== X-Received: by 2002:a17:90a:e398:: with SMTP id b24mr12899824pjz.235.1592743795918; Sun, 21 Jun 2020 05:49:55 -0700 (PDT) Received: from bubble.grove.modra.org (158.106.96.58.static.exetel.com.au. [58.96.106.158]) by smtp.gmail.com with ESMTPSA id h8sm11073506pfo.67.2020.06.21.05.49.54 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 21 Jun 2020 05:49:55 -0700 (PDT) Received: by bubble.grove.modra.org (Postfix, from userid 1000) id B5DCA84E0D; Sun, 21 Jun 2020 22:19:51 +0930 (ACST) Date: Sun, 21 Jun 2020 22:19:51 +0930 From: Alan Modra To: binutils@sourceware.org Subject: PR26132, ar creates invalid libraries for some targets with plugins enabled Message-ID: <20200621124951.GJ21885@bubble.grove.modra.org> References: <20200529031340.GH5475@bubble.grove.modra.org> <20200616030543.GC12881@bubble.grove.modra.org> <20200621074323.GH21885@bubble.grove.modra.org> <20200621124810.GI21885@bubble.grove.modra.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200621124810.GI21885@bubble.grove.modra.org> User-Agent: Mutt/1.9.4 (2018-02-28) X-Spam-Status: No, score=-12.9 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, FREEMAIL_FROM, GIT_PATCH_0, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: binutils@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Binutils mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 21 Jun 2020 12:49:58 -0000 PR 26132 * configure.ac: Disable plugins by default for some targets. * plugin.c: Comment typo fix. * configure: Regenerate. diff --git a/bfd/configure.ac b/bfd/configure.ac index 755633bdd9..1b67cb6cac 100644 --- a/bfd/configure.ac +++ b/bfd/configure.ac @@ -44,6 +44,30 @@ LT_INIT([dlopen]) # AC_PLUGINS setting $plugins is called by ACX_LARGEFILE. ACX_LARGEFILE +changequote(,)dnl +case "${target}" in + vax-*-netbsdelf*) ;; + *-*-*aout* | i[3-7]86-*-bsd* | i[3-7]86-*-msdos* | ns32k-*-* | \ + pdp11-*-* | vax-*-*bsd*) +changequote([,])dnl + if test "$plugins" = "yes"; then + if test "${enable_plugins+set}" = set; then + AC_MSG_WARN(Enabling plugins for AOUT is experimental) + else + plugins=no + fi + fi ;; + *-*-*vms* | \ + powerpc*-*-aix* | powerpc-*-beos* | powerpc-*-macos* | rs6000-*-*) + if test "$plugins" = "yes"; then + if test "${enable_plugins+set}" = set; then + AC_MSG_WARN(Enabling plugins may result in ar creating non-standard archives for ${target}) + else + plugins=no + fi + fi ;; +esac + AM_CONDITIONAL(PLUGINS, test "$plugins" = "yes") AC_ARG_ENABLE(64-bit-bfd, diff --git a/bfd/plugin.c b/bfd/plugin.c index 5ed8757809..593e277747 100644 --- a/bfd/plugin.c +++ b/bfd/plugin.c @@ -762,4 +762,4 @@ const bfd_target plugin_vec = NULL /* backend_data. */ }; -#endif /* BFD_SUPPORTS_PLUGIN */ +#endif /* BFD_SUPPORTS_PLUGINS */ -- Alan Modra Australia Development Lab, IBM