From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pg1-f179.google.com (mail-pg1-f179.google.com [209.85.215.179]) by sourceware.org (Postfix) with ESMTPS id BA43F3858D37 for ; Thu, 6 Aug 2020 06:09:14 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org BA43F3858D37 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=maskray.me Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=emacsray@gmail.com Received: by mail-pg1-f179.google.com with SMTP id t6so26136114pgq.1 for ; Wed, 05 Aug 2020 23:09:14 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=ppazWxbrDDzzm0G9BOoDMxxAgx1Ijz6Mpt12z94ucXE=; b=cNiZjYxwbzvFWcqsuN4ANo+e1K65tP/9OEiV6Ul7ee3yUQL7JjqyXhBoi/m4R5NI+Q brj0sKzuNBE8Fjk/6EQabNpvdX8ApMjmwvXWRA3pA67F1T/dNYdPpWV8CNwSjaQkRZik Iu7MNiGE1yuj8K48umbJByR6IMnCDg3TtL5jwD0mQmH+r2nI2wq7i3L/snELDUqnroHt ADS0pqOLuOVMzwe/t8oeEXtYPUGuJp/fdb5rO7v7aGhQrK+U6mQZN5gjPmfDX4Rlwd4y C9cv7XQF5nzDnxoG2+1azFejCAlWSET69rFra1ctF5GzwQUdIzfbuvAD/wy4zhHx+El5 1YlQ== X-Gm-Message-State: AOAM5322Tkvg7gOv7CAWoAM/TYWRPbYJNOt852VYW5GcoVQRpyimFxe/ GcmS8SZrjbM6ki9KpQI93n0= X-Google-Smtp-Source: ABdhPJxYMjOJyxoj07fXD72+BdUmNeDa1QlpLDkGMBPr8p0Mc/ttrzSQkt+c1Dyg2iY5vEZDZhTP5Q== X-Received: by 2002:a63:cb05:: with SMTP id p5mr6332968pgg.120.1596694153987; Wed, 05 Aug 2020 23:09:13 -0700 (PDT) Received: from localhost ([2601:647:4b01:ae80::51fb]) by smtp.gmail.com with ESMTPSA id e3sm5509576pgu.40.2020.08.05.23.09.13 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 05 Aug 2020 23:09:13 -0700 (PDT) Date: Wed, 5 Aug 2020 23:09:12 -0700 From: Fangrui Song To: Nelson Chu Cc: Mark Wielaard , Tom Tromey , Alan Modra , Nick Clifton via Binutils Subject: Re: gas: Use udata for DW_AT_high_pc when emitting DWARF4 (Was: Broken GAS DWARF tests) Message-ID: <20200806060912.7i64gnddn5bahyix@gmail.com> References: <875za52hbk.fsf@tromey.com> <3904dd15-3952-ba23-4efe-db493c6a3910@redhat.com> <20200803131109.GA2718@wildebeest.org> <20200803201127.GB2718@wildebeest.org> <20200804035336.GJ9601@bubble.grove.modra.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii; format=flowed Content-Disposition: inline In-Reply-To: <20200804035336.GJ9601@bubble.grove.modra.org> X-Spam-Status: No, score=-3.6 required=5.0 tests=BAYES_00, FREEMAIL_FORGED_FROMDOMAIN, FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS, KAM_DMARC_STATUS, KAM_INFOUSMEBIZ, RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H3, RCVD_IN_MSPIKE_WL, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=no autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: binutils@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Binutils mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 06 Aug 2020 06:09:15 -0000 On 2020-08-04, Alan Modra via Binutils wrote: >On Mon, Aug 03, 2020 at 10:11:27PM +0200, Mark Wielaard wrote: >> * dwarf2dbg.c (out_debug_abbrev): When DWARF2_VERSION >= 4, use >> DW_FORM_udata for DW_AT_high_pc. >> (out_debug_info): Use emit_leb128_expr for DW_AT_high_pc, when >> DWARF2_VERSION >= 4. >> * read.c (emit_leb128_exp): No longer static. >> * read.h (emit_leb128_exp): Define. > >OK, looks good. Note that there have been problems in the past >resolving leb128 expressions (eg. see 38cf168be581), so please keep an >eye out for regressions. > >-- >Alan Modra >Australia Development Lab, IBM Using DWARF v3 attribute class 'address' for DW_AT_high_pc can save a relocation on RISC-V in -mrelax mode