From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pl1-x632.google.com (mail-pl1-x632.google.com [IPv6:2607:f8b0:4864:20::632]) by sourceware.org (Postfix) with ESMTPS id 988B13857C53 for ; Mon, 24 Aug 2020 16:38:07 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 988B13857C53 Received: by mail-pl1-x632.google.com with SMTP id s14so4494123plp.4 for ; Mon, 24 Aug 2020 09:38:07 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:subject:message-id:mime-version :content-disposition:user-agent; bh=uHMFVNM05+EBomcbIH977h1GM2Y3vk4JTMxgYDqxb5Y=; b=AsU1lXhHW/5sIisJ/Ow4E7dbETxcgDSL6SxQXJEv0eMENv9BM8NtPsfjE1r6ti1fHI vsSBVjj8ANdYdTUAFoFYwp6kGgd13/31CMtNL8g/HnksnYRDkmTY8TMGSxoPsvAFQv4c Nvh7CyRBeX14qzG0VhKc46PqALLFHtgE3jsuFP3ROhZAUZsJ1/BB7KCBqJF1dG4Qh9IU PHrG7Eb7H92Q7Oc+U0AeCbSFE4kjJM4emBNcIZNaPEulaaqtWlxYHUbjTCwYO1Yiev3g St4r6FlIo6vlWIND47ghuC7k06H2RSDl5JXUGKBeIjo1FU0e36hwBZyCeVN6sGJetTdi cxyA== X-Gm-Message-State: AOAM533wY9w+3uJZtI9CrIVvl4NXH7SEV5vEpqcdZ+/BoK9tmmIDFQJJ nwYXqH9aBLxJN2kSzcbHiEswseUuFbsRWQ== X-Google-Smtp-Source: ABdhPJzRsIoqtUCrCrVrBaU47ix3JVCX1WVOgVkMoB0Qn/EDZRLyzvYER2gAiZW2honfdfwweKLq0g== X-Received: by 2002:a17:90b:f83:: with SMTP id ft3mr114895pjb.197.1598287082204; Mon, 24 Aug 2020 09:38:02 -0700 (PDT) Received: from bubble.grove.modra.org (158.106.96.58.static.exetel.com.au. [58.96.106.158]) by smtp.gmail.com with ESMTPSA id g8sm11069206pfo.132.2020.08.24.09.38.00 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 24 Aug 2020 09:38:01 -0700 (PDT) Received: by bubble.grove.modra.org (Postfix, from userid 1000) id 609D887F1B; Tue, 25 Aug 2020 02:07:57 +0930 (ACST) Date: Tue, 25 Aug 2020 02:07:57 +0930 From: Alan Modra To: binutils@sourceware.org Subject: PR26483, ASAN: ppc_elf_link_params elf32-ppc.c:2314 Message-ID: <20200824163757.GL15695@bubble.grove.modra.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline User-Agent: Mutt/1.9.4 (2018-02-28) X-Spam-Status: No, score=-12.1 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, FREEMAIL_FROM, GIT_PATCH_0, KAM_NUMSUBJECT, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: binutils@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Binutils mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 24 Aug 2020 16:38:09 -0000 PR 26483 * elf32-ppc.c (ppc_elf_hash_table): Test is_elf_hash_table before accessing elf_hash_table_id. diff --git a/bfd/elf32-ppc.c b/bfd/elf32-ppc.c index 43c0e18896..d5b8a6627a 100644 --- a/bfd/elf32-ppc.c +++ b/bfd/elf32-ppc.c @@ -2230,8 +2230,9 @@ struct ppc_elf_link_hash_table /* Get the PPC ELF linker hash table from a link_info structure. */ #define ppc_elf_hash_table(p) \ - (elf_hash_table_id ((struct elf_link_hash_table *) ((p)->hash)) \ - == PPC32_ELF_DATA ? ((struct ppc_elf_link_hash_table *) ((p)->hash)) : NULL) + ((is_elf_hash_table ((p)->hash) \ + && elf_hash_table_id (elf_hash_table (p)) == PPC32_ELF_DATA) \ + ? ((struct ppc_elf_link_hash_table *) ((p)->hash)) : NULL) /* Create an entry in a PPC ELF linker hash table. */ -- Alan Modra Australia Development Lab, IBM