From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pj1-x1029.google.com (mail-pj1-x1029.google.com [IPv6:2607:f8b0:4864:20::1029]) by sourceware.org (Postfix) with ESMTPS id B4961385703A for ; Wed, 26 Aug 2020 13:45:11 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org B4961385703A Received: by mail-pj1-x1029.google.com with SMTP id z18so906339pjr.2 for ; Wed, 26 Aug 2020 06:45:11 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:subject:message-id:mime-version :content-disposition:user-agent; bh=AhxgJvUluxs7PS6F4D2D88zcEiSWafop9xUWCSibtZw=; b=lJro58CDuJDW7I1hZpF89Br9v0i63x9mef6Fb5RmXWzf5gnkAURafwRv+bd3seuEdj rZckwSL+uG7RTMQYa/Febu0nGPb37CuLJFSKyNsco7v6eTHk25/GiQySpB7SqALMJfFN 77TY5WSyQwIDYUGPkfrxFiLXg8pXBRJvBghTKB4eHRfwVKTq6F64dclLDsqw6MvytK3R sTlUDNRkx1labsh3FQA+q5xWdiijqGafXd72AS0gauYgDV3k/HPbXfUGPtej89EPR97u GeGjyA/sGKj742goZzq9mYQb1N9tCkevLoZ80bjrltmwugko0OZX/6SOlEZ4hbqJUdjG 4n8Q== X-Gm-Message-State: AOAM531cqCIUBrhUYufbhtabtjn1+e3C3OZHFpVSUkpYgQvZfWUv4gCo 5V6u9IWq2tXecQlP5AR6qgkAtCcaTQYs8A== X-Google-Smtp-Source: ABdhPJxYi6AvCE8xvI7Sic8wYn3SlGYiQQUb436u4tdxVjh+ZGF4H5yAxsw8YE5ODVD+5m4VHRR8hA== X-Received: by 2002:a17:90a:e16:: with SMTP id v22mr960022pje.124.1598449510558; Wed, 26 Aug 2020 06:45:10 -0700 (PDT) Received: from bubble.grove.modra.org ([2406:3400:51d:8cc0:79a9:1aa:e066:2d47]) by smtp.gmail.com with ESMTPSA id z26sm3087902pfa.55.2020.08.26.06.45.09 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 26 Aug 2020 06:45:09 -0700 (PDT) Received: by bubble.grove.modra.org (Postfix, from userid 1000) id 009168153B; Wed, 26 Aug 2020 23:15:05 +0930 (ACST) Date: Wed, 26 Aug 2020 23:15:05 +0930 From: Alan Modra To: binutils@sourceware.org Subject: PR26415 UBSAN: vms-misc.c:636 left shift cannot be represented Message-ID: <20200826134505.GF15695@bubble.grove.modra.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline User-Agent: Mutt/1.9.4 (2018-02-28) X-Spam-Status: No, score=-10.2 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, FREEMAIL_FROM, GIT_PATCH_0, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: binutils@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Binutils mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 26 Aug 2020 13:45:12 -0000 An unsigned short value is promoted to int, thus triggering UB on a left shift of a positive value that results in a negative int. PR 26415 * vms-misc.c (vms_time_t_to_vms_time): Don't use unsigned short vars. diff --git a/bfd/vms-misc.c b/bfd/vms-misc.c index d040c79de1..0826456ef0 100644 --- a/bfd/vms-misc.c +++ b/bfd/vms-misc.c @@ -592,8 +592,8 @@ vms_time_to_time_t (unsigned int hi, unsigned int lo) void vms_time_t_to_vms_time (time_t ut, unsigned int *hi, unsigned int *lo) { - unsigned short val[4]; - unsigned short tmp[4]; + unsigned int val[4]; + unsigned int tmp[4]; unsigned int carry; int i; -- Alan Modra Australia Development Lab, IBM