public inbox for binutils@sourceware.org
 help / color / mirror / Atom feed
* Re: commit eae0b5c3b2d6b
@ 2020-08-27 12:27 Alan Modra
  0 siblings, 0 replies; only message in thread
From: Alan Modra @ 2020-08-27 12:27 UTC (permalink / raw)
  To: binutils

	PR 26416
	* elf64-alpha.c (elf64_alpha_relax_tls_get_addr): Correct "dynamic".

diff --git a/bfd/elf64-alpha.c b/bfd/elf64-alpha.c
index fd1f4b20be..7b708f1e9d 100644
--- a/bfd/elf64-alpha.c
+++ b/bfd/elf64-alpha.c
@@ -3464,9 +3464,8 @@ elf64_alpha_relax_tls_get_addr (struct alpha_relax_info *info, bfd_vma symval,
   bfd_boolean dynamic, use_gottprel;
   unsigned long new_symndx;
 
-  if (info->h == NULL)
-    return TRUE; /* FIXME: Should this be return FALSE ?  */
-  dynamic = alpha_elf_dynamic_symbol_p (&info->h->root, info->link_info);
+  dynamic = (info->h != NULL
+	     && alpha_elf_dynamic_symbol_p (&info->h->root, info->link_info));
 
   /* If a TLS symbol is accessed using IE at least once, there is no point
      to use dynamic model for it.  */

-- 
Alan Modra
Australia Development Lab, IBM

^ permalink raw reply	[flat|nested] only message in thread

only message in thread, other threads:[~2020-08-27 12:28 UTC | newest]

Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-08-27 12:27 commit eae0b5c3b2d6b Alan Modra

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).