public inbox for binutils@sourceware.org
 help / color / mirror / Atom feed
From: Alan Modra <amodra@gmail.com>
To: "H.J. Lu" <hjl.tools@gmail.com>
Cc: binutils@sourceware.org
Subject: Re: [PATCH] elf: Don't load archive element after dynamic definition
Date: Thu, 27 Aug 2020 23:23:12 +0930	[thread overview]
Message-ID: <20200827135311.GD15695@bubble.grove.modra.org> (raw)
In-Reply-To: <20200825172842.1212936-1-hjl.tools@gmail.com>

On Tue, Aug 25, 2020 at 10:28:42AM -0700, H.J. Lu via Binutils wrote:
> Don't load the archive element after seeing a definition in a shared
> object.
> 
> bfd/
> 
> 	PR ld/26530
> 	* elflink.c (elf_link_add_object_symbols): Also preserve the
> 	dynamic_def bit for --as-needed.
> 	(elf_link_add_archive_symbols): Don't load the archive element
> 	after seeing a definition in a shared object.

This seems over complicated to me.  Why don't we just load the
as-needed shared library on the first pass?

-- 
Alan Modra
Australia Development Lab, IBM

  reply	other threads:[~2020-08-27 13:53 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-08-25 17:28 H.J. Lu
2020-08-27 13:53 ` Alan Modra [this message]
2020-08-27 14:05   ` H.J. Lu
2020-08-28  1:58     ` Alan Modra
2020-08-28 12:53       ` H.J. Lu
2020-08-28 14:49         ` Alan Modra
2020-08-28 14:50           ` H.J. Lu
2020-09-02  6:52             ` Martin Liška
2020-09-02  8:12               ` Alan Modra
2020-09-02 11:56                 ` H.J. Lu
2020-09-02 13:05                   ` Alan Modra
2020-09-02 13:22                     ` H.J. Lu
2020-09-02 14:29                       ` Alan Modra
2020-09-02 14:35                         ` H.J. Lu
2020-09-03  1:31                           ` Alan Modra
2020-09-03  2:16                             ` H.J. Lu
2020-09-03  6:07                               ` Alan Modra
2020-09-03 11:34                                 ` H.J. Lu
2020-09-04  7:25                                   ` Alan Modra
2020-09-04 11:06                                     ` H.J. Lu
2020-09-08  5:42                                       ` Alan Modra
2020-09-08 12:43                                         ` H.J. Lu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200827135311.GD15695@bubble.grove.modra.org \
    --to=amodra@gmail.com \
    --cc=binutils@sourceware.org \
    --cc=hjl.tools@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).