From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wm1-x335.google.com (mail-wm1-x335.google.com [IPv6:2a00:1450:4864:20::335]) by sourceware.org (Postfix) with ESMTPS id 63D083851C09 for ; Thu, 27 Aug 2020 20:03:44 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 63D083851C09 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=mittosystems.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=jozef.l@mittosystems.com Received: by mail-wm1-x335.google.com with SMTP id q9so4103547wmj.2 for ; Thu, 27 Aug 2020 13:03:44 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=mittosystems.com; s=google; h=date:from:to:subject:message-id:mail-followup-to:mime-version :content-disposition; bh=J6A85De8tuJne0zZNEnH9Inb2p8uRUWB3p+2Q+TE8yo=; b=MhyO/Ft7CkTlnj77QrW9SmyFgGh0zwM/OuRk28z62H2XOIlLXHDgNJBvGu/FOEmv6U dzCNBKAZK1IMm9ZEVdKGO51/57008Qe4O2vBAy/7YEEYleMGQtI+SIriCvybeqy2Y6zp EePWaU0rwnFo0G6HTtdHyua1IF/NapSkME0YxDrqBOlAUNHksIinQ2k+DHwirhc6QUJT rOvZZyz4iW/rRxxM1jM6Qm7PqxfTHRkiK4UbLy/FJGG0E1PluaWAWcRVLebihYXXVus7 Bd/7+d0EMeCCZNJ+2nA1ItQrQoCG3R3DFlxp3CQ2pi0n9LdD8zu6gnaA4knm3mVlVoJO HfUA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:subject:message-id:mail-followup-to :mime-version:content-disposition; bh=J6A85De8tuJne0zZNEnH9Inb2p8uRUWB3p+2Q+TE8yo=; b=q2KftGEuyAMVyVvQB4x4gJOlOnVZW3CN1OzBPF5lbaUN0mrX2vJeV7PU3umPeJLHuh fyzIRo8CSMi6sJY3m+TdpQyiSgY4Pnv94rUuyB0o6gHV4JrY4Po85EieYSxbXa7/qEv/ GTKf8E32zRN6IzfsFz9vY7ebCdbNJaPNRO9gEymQH1k4xyWHH20PFBrHja/bFoUY3Seq Vxtj3EyuGjFEp1b+7zSDg00eqRk3uQzkJeAJWi0nUwcWmamuzo3NGGb5ve8AU7HJ0H+O qb6yw8xoRzNHRzUs4kzt++y/v6DuzIl03FOLlAvqWl/KOH0+wsv/YIXt/F63JoqkZHus fkbA== X-Gm-Message-State: AOAM531tVxX4F3ASWBSyTA0KvvK6tpEc+SphnoVhiPJ1fMXUxC5Ys5F4 zFRfQYVzi6VpzTbHQwZdhNplLXqZDplkmA== X-Google-Smtp-Source: ABdhPJzroiap6xrnEjJ/K4JHcMHY4Y/S9rhuSYWL/8piZ7092LCqicrWeVVwQzBgWCFloPX7vqAoiA== X-Received: by 2002:a1c:4d14:: with SMTP id o20mr448134wmh.115.1598558623104; Thu, 27 Aug 2020 13:03:43 -0700 (PDT) Received: from jozef-acer-manjaro ([2a01:4b00:87fd:900:5e1d:5c99:56da:76e8]) by smtp.gmail.com with ESMTPSA id o128sm7304038wmo.39.2020.08.27.13.03.41 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 27 Aug 2020 13:03:42 -0700 (PDT) Date: Thu, 27 Aug 2020 21:03:40 +0100 From: Jozef Lawrynowicz To: binutils@sourceware.org Subject: [committed] readelf: MSP430: Fix incorrect usage of "msp430x" in function names Message-ID: <20200827200340.hzykndcvpn4gr5hx@jozef-acer-manjaro> Mail-Followup-To: binutils@sourceware.org MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="vcnib2qtxskvsupb" Content-Disposition: inline X-Spam-Status: No, score=-10.6 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, GIT_PATCH_0, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: binutils@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Binutils mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 27 Aug 2020 20:03:45 -0000 --vcnib2qtxskvsupb Content-Type: text/plain; charset=us-ascii Content-Disposition: inline The "X" in "MSP430X" indicates an extension to the original MSP430 ISA, but these functions are generically used for all MSP430 ISAs, so the names should not use the "X" suffix. Successfully regtested the Binutils testsuite. Committed as obvious. --vcnib2qtxskvsupb Content-Type: text/plain; charset=us-ascii Content-Disposition: attachment; filename="0001-readelf-MSP430-Fix-incorrect-usage-of-msp430x-in-fun.patch" >From b0191216046cca6affd74b3bfebdb124ad5f428e Mon Sep 17 00:00:00 2001 From: Jozef Lawrynowicz Date: Thu, 27 Aug 2020 20:48:35 +0100 Subject: [PATCH] readelf: MSP430: Fix incorrect usage of "msp430x" in function names The "X" in "MSP430X" indicates an extension to the original MSP430 ISA, but these functions are generically used for all MSP430 ISAs, so the names should not use the "X" suffix. binutils/ChangeLog: * readelf.c (get_msp430x_section_type_name): Rename to ... (get_msp430_section_type_name): ... this. (get_section_type_name): Use get_msp430_section_type_name. (display_msp430x_attribute): Rename to ... (display_msp430_attribute): ... this. (process_arch_specific): Use display_msp430_attribute. --- binutils/ChangeLog | 9 +++++++++ binutils/readelf.c | 8 ++++---- 2 files changed, 13 insertions(+), 4 deletions(-) diff --git a/binutils/ChangeLog b/binutils/ChangeLog index e5e33867200..22d95e2b725 100644 --- a/binutils/ChangeLog +++ b/binutils/ChangeLog @@ -1,3 +1,12 @@ +2020-08-27 Jozef Lawrynowicz + + * readelf.c (get_msp430x_section_type_name): Rename to ... + (get_msp430_section_type_name): ... this. + (get_section_type_name): Use get_msp430_section_type_name. + (display_msp430x_attribute): Rename to ... + (display_msp430_attribute): ... this. + (process_arch_specific): Use display_msp430_attribute. + 2020-08-27 John David Anglin PR 26356 diff --git a/binutils/readelf.c b/binutils/readelf.c index d4dcab841a6..3758ff14bfd 100644 --- a/binutils/readelf.c +++ b/binutils/readelf.c @@ -4267,7 +4267,7 @@ get_tic6x_section_type_name (unsigned int sh_type) } static const char * -get_msp430x_section_type_name (unsigned int sh_type) +get_msp430_section_type_name (unsigned int sh_type) { switch (sh_type) { @@ -4384,7 +4384,7 @@ get_section_type_name (Filedata * filedata, unsigned int sh_type) result = get_tic6x_section_type_name (sh_type); break; case EM_MSP430: - result = get_msp430x_section_type_name (sh_type); + result = get_msp430_section_type_name (sh_type); break; case EM_NFP: result = get_nfp_section_type_name (sh_type); @@ -16174,7 +16174,7 @@ display_raw_attribute (unsigned char * p, unsigned char const * const end) } static unsigned char * -display_msp430x_attribute (unsigned char * p, +display_msp430_attribute (unsigned char * p, const unsigned char * const end) { unsigned int val; @@ -20110,7 +20110,7 @@ process_arch_specific (Filedata * filedata) case EM_MSP430: return process_attributes (filedata, "mspabi", SHT_MSP430_ATTRIBUTES, - display_msp430x_attribute, + display_msp430_attribute, display_msp430_gnu_attribute); case EM_RISCV: -- 2.28.0 --vcnib2qtxskvsupb--