From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pl1-x62b.google.com (mail-pl1-x62b.google.com [IPv6:2607:f8b0:4864:20::62b]) by sourceware.org (Postfix) with ESMTPS id F17A9393C876 for ; Sun, 30 Aug 2020 13:20:17 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org F17A9393C876 Received: by mail-pl1-x62b.google.com with SMTP id j11so1760744plk.9 for ; Sun, 30 Aug 2020 06:20:17 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:subject:message-id:mime-version :content-disposition:user-agent; bh=twM9pnREpKAN4+frIAQSDJ3gJkVboo+COFn5mbabJzs=; b=PHArJDEsqCChz9y8icL6RkfwxzHAuNqXu1M6NLv1vCsPRLD/fBwUH7EqLdVsL2IpJ7 pYOztGUx/68OUqxtev3gj1M7maM5XE2w0y+nSE7eWDlEa2dXt+ufNazvNikCKNRQgrCH AhIMENLAfcMhgfPOR+YzAb7qEc4Mxz4XUVurDptjO+L8Eaxkw9d98yGxIpCFeb+hklFT Pg2Y4V7f+9WZ8hWMIjj5+l8hEHk2J2vSR48ZKo2XNc6kenxY6hRihhlA3RijxhX+YXx/ NWbea29JNyeHWMNi1aVwFxNGhLirPIG1K4MV1OjanksmUDPEfB7IHvfFIzFmFQrBucMF aiaQ== X-Gm-Message-State: AOAM532k7J3fFVuIxM+HG5poCQEHqZ8WkZAJN5N1akz3QRhXAGgUiFSy OGrndj2wQ91ONiWBtQNPoxjLnybBKEA8Bg== X-Google-Smtp-Source: ABdhPJywmKBewGBtKvPNFWTG4ZM8XaiUfqY7adIXBsosMKbS6Yf0PEQAVXv5iN4jT08sKTkIaormHQ== X-Received: by 2002:a17:90b:138d:: with SMTP id hr13mr6215575pjb.14.1598793616854; Sun, 30 Aug 2020 06:20:16 -0700 (PDT) Received: from bubble.grove.modra.org (158.106.96.58.static.exetel.com.au. [58.96.106.158]) by smtp.gmail.com with ESMTPSA id fs12sm4298397pjb.21.2020.08.30.06.20.15 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 30 Aug 2020 06:20:16 -0700 (PDT) Received: by bubble.grove.modra.org (Postfix, from userid 1000) id 3FA0B86EC9; Sun, 30 Aug 2020 22:50:10 +0930 (ACST) Date: Sun, 30 Aug 2020 22:50:10 +0930 From: Alan Modra To: binutils@sourceware.org Subject: readelf: ubsan: shift exponent 32 is too large Message-ID: <20200830132006.GW15695@bubble.grove.modra.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline User-Agent: Mutt/1.9.4 (2018-02-28) X-Spam-Status: No, score=-12.5 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, FREEMAIL_FROM, GIT_PATCH_0, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: binutils@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Binutils mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 30 Aug 2020 13:20:28 -0000 When compiled on a 32-bit host, a temp var is too small for possible 64-bit values to be calculated. * readelf.c (print_gnu_build_attribute_name): Make "bytes" unsigned long long. diff --git a/binutils/readelf.c b/binutils/readelf.c index f02848e468..94aa876b5a 100644 --- a/binutils/readelf.c +++ b/binutils/readelf.c @@ -19662,7 +19662,7 @@ print_gnu_build_attribute_name (Elf_Internal_Note * pnote) while (bytes --) { - unsigned long byte = (* name ++) & 0xff; + unsigned long long byte = *name++ & 0xff; val |= byte << shift; shift += 8; -- Alan Modra Australia Development Lab, IBM