From: Alan Modra <amodra@gmail.com>
To: Alex Coplan <Alex.Coplan@arm.com>
Cc: "nickc@redhat.com" <nickc@redhat.com>,
"H.J. Lu" <hjl.tools@gmail.com>,
Binutils <binutils@sourceware.org>
Subject: Re: [PATCH] gas: Fix internal error in S_SET_SEGMENT
Date: Wed, 2 Sep 2020 09:14:10 +0930 [thread overview]
Message-ID: <20200901234409.GG15695@bubble.grove.modra.org> (raw)
In-Reply-To: <VI1PR08MB4029E184A2B97225253B96C5EA2E0@VI1PR08MB4029.eurprd08.prod.outlook.com>
On Tue, Sep 01, 2020 at 03:47:44PM +0000, Alex Coplan wrote:
> > > >> 2020-08-03 Alex Coplan <alex.coplan@arm.com>
> > > >>
> > > >> * config/obj-elf.c (obj_elf_change_section): When repurposing an
> > > >> existing symbol, ensure that we set sy_value as per other (fresh)
> > > >> section symbols.
> > > >> * testsuite/gas/elf/elf.exp: Add new test.
> > > >> * testsuite/gas/elf/section-symbol-redef.d: New test.
> > > >> * testsuite/gas/elf/section-symbol-redef.s: Input for test.
> > >
> > > Approved - please apply.
> >
> > Committed with one obvious change [...]
>
> This applies and tests cleanly on the 2.35 branch. OK to backport?
No, in my opinion this doesn't count as a regression or a serious
enough bug to risk the chance that the fix is imperfect.
--
Alan Modra
Australia Development Lab, IBM
prev parent reply other threads:[~2020-09-01 23:44 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-22 14:23 Alex Coplan
2020-07-22 14:40 ` H.J. Lu
2020-08-03 14:22 ` Alex Coplan
2020-08-17 9:07 ` Alex Coplan
2020-08-17 11:26 ` Nick Clifton
2020-08-17 13:28 ` Alex Coplan
2020-09-01 15:47 ` Alex Coplan
2020-09-01 23:44 ` Alan Modra [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200901234409.GG15695@bubble.grove.modra.org \
--to=amodra@gmail.com \
--cc=Alex.Coplan@arm.com \
--cc=binutils@sourceware.org \
--cc=hjl.tools@gmail.com \
--cc=nickc@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).