From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pf1-x441.google.com (mail-pf1-x441.google.com [IPv6:2607:f8b0:4864:20::441]) by sourceware.org (Postfix) with ESMTPS id AD7AA3857C49 for ; Tue, 1 Sep 2020 23:44:16 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org AD7AA3857C49 Received: by mail-pf1-x441.google.com with SMTP id f18so1771445pfa.10 for ; Tue, 01 Sep 2020 16:44:16 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=U41OTjizLFg9aRKzIAwL8Q6QbIRGZuqsnEMDybFZO8A=; b=krlxgSy7eXfFjKWzH5wbfCCjhfpM1RDq/u+hh0q3005o3x/1o3zFbm29ZYZjw2QeiX aEJXe/ZuMJ4ApO6V+bx/wxuek8sPVkn0EZ4Bdv4MhgXfG6drnx8kdvKu12Ym3x2pzcf2 W1THEi0xa7++5AMGwVfCV+qMswnMrWZ1PwW5QM5xvMSgjXU3FYohgRlIxNh1lnKNd2+5 x0Rh07fMYwI2Guhj8A6RMp04AhxbjQGPBQl9bauUWeZEiJHMDfj9BA6d/vCrKHc1u3zD htEWo7Xel9rwkk5e3agx/GZK/gJV/98SQHx/6VKx/2vQ2uY+EsiGC63B1YXXFtFBJg8y z+lw== X-Gm-Message-State: AOAM530npFYIaDxT4FuGAuLxcLs+HmvkqMwzQ+qysv8Mz2XFOAcxUY09 J18YoUHzcbvfxXp1cT5WpV0= X-Google-Smtp-Source: ABdhPJwnLPntqHiPhGZJQuMQ+YPY0jAubdoXi+mXfvHojzQ89WoUnyHy8MiLO1l1tT2x3EbX0lclVQ== X-Received: by 2002:a62:4d41:: with SMTP id a62mr621397pfb.234.1599003855835; Tue, 01 Sep 2020 16:44:15 -0700 (PDT) Received: from bubble.grove.modra.org (158.106.96.58.static.exetel.com.au. [58.96.106.158]) by smtp.gmail.com with ESMTPSA id 144sm3257304pfu.114.2020.09.01.16.44.14 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 01 Sep 2020 16:44:15 -0700 (PDT) Received: by bubble.grove.modra.org (Postfix, from userid 1000) id 6DE7786EA6; Wed, 2 Sep 2020 09:14:10 +0930 (ACST) Date: Wed, 2 Sep 2020 09:14:10 +0930 From: Alan Modra To: Alex Coplan Cc: "nickc@redhat.com" , "H.J. Lu" , Binutils Subject: Re: [PATCH] gas: Fix internal error in S_SET_SEGMENT Message-ID: <20200901234409.GG15695@bubble.grove.modra.org> References: <20200722142302.wi2rotbr3hbz57iw@arm.com> <20200803142241.jxtqma5ijk3243vg@arm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.9.4 (2018-02-28) X-Spam-Status: No, score=-7.6 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, FREEMAIL_FROM, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: binutils@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Binutils mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 01 Sep 2020 23:44:18 -0000 On Tue, Sep 01, 2020 at 03:47:44PM +0000, Alex Coplan wrote: > > > >> 2020-08-03 Alex Coplan > > > >> > > > >> * config/obj-elf.c (obj_elf_change_section): When repurposing an > > > >> existing symbol, ensure that we set sy_value as per other (fresh) > > > >> section symbols. > > > >> * testsuite/gas/elf/elf.exp: Add new test. > > > >> * testsuite/gas/elf/section-symbol-redef.d: New test. > > > >> * testsuite/gas/elf/section-symbol-redef.s: Input for test. > > > > > > Approved - please apply. > > > > Committed with one obvious change [...] > > This applies and tests cleanly on the 2.35 branch. OK to backport? No, in my opinion this doesn't count as a regression or a serious enough bug to risk the chance that the fix is imperfect. -- Alan Modra Australia Development Lab, IBM