From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pg1-x534.google.com (mail-pg1-x534.google.com [IPv6:2607:f8b0:4864:20::534]) by sourceware.org (Postfix) with ESMTPS id 746BD3971C53 for ; Wed, 2 Sep 2020 08:44:05 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 746BD3971C53 Received: by mail-pg1-x534.google.com with SMTP id u13so1271922pgh.1 for ; Wed, 02 Sep 2020 01:44:05 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=Sx0RGyOTd4+unoGGtJzbmm1BRRASNODtrvvDaAasuX8=; b=LaAZg99aTNyny33uU7hso5VatzmczgQQspE74JLc4OnweuqOf/zXQ1GztmE6fPQ96D O8DNwPxEEXvyFD92MqCitn1E/YP0xRoWNObCpTHRDzNo0B5uk8rm8HICH8TysUpiWbnk 9Gomoo3GveLNFi2oS4jJ6TYBPcYHQQfoazFFCx2jA2adVDKqMqmHOEYoxZ+B3BxaUUlf m91ZC+o+uVexbJcA5zccGIc4fN9XYOnjvcZrVqfoKU48bbJXPyVPeue9SJ6xr7VFIQx1 nkvXgjJ5BiH/jxt+qJ3BCxyJKKq5Ew/HSyWHN9y9dxoSuvvt3Rw7x7sPmGazwLIomnQT Ywlg== X-Gm-Message-State: AOAM530cQ4IKHHBinPMueK9WOCFQjqSP3+tJliHWQSDY0OdIflyL3SBw DUbZ1UW32KrFqhVbHZxfUXlp1YXAwnE= X-Google-Smtp-Source: ABdhPJyRdHJAIoTPTM5UrR1S5+Vrt1eBscXnBDWi5C/VmmjJ6lvwqR+p1IARmDIbE3buG7B/Zis0Uw== X-Received: by 2002:a63:455d:: with SMTP id u29mr1172324pgk.178.1599036244344; Wed, 02 Sep 2020 01:44:04 -0700 (PDT) Received: from bubble.grove.modra.org ([2406:3400:51d:8cc0:84c2:3a8b:c3d4:afab]) by smtp.gmail.com with ESMTPSA id r144sm5123369pfc.63.2020.09.02.01.44.02 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 02 Sep 2020 01:44:03 -0700 (PDT) From: Alan Modra To: binutils@sourceware.org Subject: ubsan: expr.c:1725,1741 signed integer overflow Date: Wed, 2 Sep 2020 18:12:56 +0930 Message-Id: <20200902084302.26786-13-amodra@gmail.com> X-Mailer: git-send-email 2.17.1 X-Spam-Status: No, score=-10.5 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, FREEMAIL_FROM, GIT_PATCH_0, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: binutils@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Binutils mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 02 Sep 2020 08:44:06 -0000 * expr.c (add_to_result, subtract_from_result): Use unsigned addition and subtraction. diff --git a/gas/expr.c b/gas/expr.c index da4fbcf8cd..6f74de786d 100644 --- a/gas/expr.c +++ b/gas/expr.c @@ -1722,7 +1722,7 @@ add_to_result (expressionS *resultP, offsetT amount, int rhs_highbit) valueT ures = resultP->X_add_number; valueT uamount = amount; - resultP->X_add_number += amount; + resultP->X_add_number += uamount; resultP->X_extrabit ^= rhs_highbit; @@ -1738,7 +1738,7 @@ subtract_from_result (expressionS *resultP, offsetT amount, int rhs_highbit) valueT ures = resultP->X_add_number; valueT uamount = amount; - resultP->X_add_number -= amount; + resultP->X_add_number -= uamount; resultP->X_extrabit ^= rhs_highbit; -- Alan Modra Australia Development Lab, IBM