From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pg1-x52f.google.com (mail-pg1-x52f.google.com [IPv6:2607:f8b0:4864:20::52f]) by sourceware.org (Postfix) with ESMTPS id 2CE3D397246D for ; Thu, 3 Sep 2020 01:05:18 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 2CE3D397246D Received: by mail-pg1-x52f.google.com with SMTP id u13so717890pgh.1 for ; Wed, 02 Sep 2020 18:05:18 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to:user-agent; bh=AX6SXwWvg2QF2RxgrU1jNeR4YiDs7eNk3uUZj6JhRvM=; b=B1gxf93pbsGSH0Zfp84cNgWFMqo9L9acAPWMJS/DXq1m2GbogfGOS27r8d1lcqUUyn VTshESuJ97SHrM8o4g/g5oShIS+k4nfuJmj9w0oWbmMZsSrzmJjVhZGTE99Z28DRiP7Q TjVSfhZa+hIFzUc1qiQtCNXqEiQ2sR3pk7Nk7AYmufEkEvtgkIDnekJRaF0VK1+ktFWm 1UtCj+/iCWoj7o5ccRgTvssPaKZc1H3dZlyrMDNQfaBXThZjYwMiENecvtsewlQb8jhY 0xzoFxB0YxzYfpqZzTgVDGR8GcNTuEMRuaUM79MiCCt/Ac8mb9F0xUzVJymCxjdyd9YQ OG0w== X-Gm-Message-State: AOAM531jXbhI15je/0z3wnhiFvPGqtN5itaF/EMAtvmY9ekHucJ5YJFC opBsJYrzAudIi5q4vvwLxWdQJMT0H+8= X-Google-Smtp-Source: ABdhPJxvpYvCNV79DsjGK+M1/lTMnbKF9OToi2SWBh3YgB47JOtOQRLIvp7NL986R3a3exKPnpbogg== X-Received: by 2002:a17:902:e787:: with SMTP id cp7mr1038625plb.125.1599095116926; Wed, 02 Sep 2020 18:05:16 -0700 (PDT) Received: from bubble.grove.modra.org (158.106.96.58.static.exetel.com.au. [58.96.106.158]) by smtp.gmail.com with ESMTPSA id w9sm518979pgg.76.2020.09.02.18.05.15 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 02 Sep 2020 18:05:16 -0700 (PDT) Received: by bubble.grove.modra.org (Postfix, from userid 1000) id 3948287AC1; Thu, 3 Sep 2020 10:35:12 +0930 (ACST) Date: Thu, 3 Sep 2020 10:35:12 +0930 From: Alan Modra To: Martin =?utf-8?B?TGnFoWth?= Cc: binutils@sourceware.org Subject: Re: Redo gas local symbol support Message-ID: <20200903010512.GL15695@bubble.grove.modra.org> References: <20200821102043.GC15695@bubble.grove.modra.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: User-Agent: Mutt/1.9.4 (2018-02-28) X-Spam-Status: No, score=-7.6 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, FREEMAIL_FROM, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: binutils@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Binutils mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 03 Sep 2020 01:05:21 -0000 On Mon, Aug 24, 2020 at 09:52:57AM +0200, Martin Liška wrote: > Hey. > > Just to inform you, the patch introduced a nice speed up: > https://sourceware.org/bugzilla/show_bug.cgi?id=26381#c9 > > Is there still anything obvious from the perf report that > suggests what can be improved now? No, I didn't see anything obvious in the perf report. No doubt the major thing that helped speed with the local symbol changes was simply combining the struc local_symbol and struct symbol hash tables, resulting in fewer hash table searches. The patch also reduced copying of memory when converting local_symbol to symbol, but any gain there would be offset somewhat by needing an extra pointer deref for struct xsymbol fields. I guess I did remove one pointer dereference by doing away with your struct symbol_entry where you had hash table entry info, hash and name, with a pointer to the symbol struct, instead putting the hash table entry info directly into the symbol structs. That trick might work for some of the other hash tables. -- Alan Modra Australia Development Lab, IBM