From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pj1-x1034.google.com (mail-pj1-x1034.google.com [IPv6:2607:f8b0:4864:20::1034]) by sourceware.org (Postfix) with ESMTPS id CE1643857001 for ; Tue, 15 Sep 2020 12:00:51 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org CE1643857001 Received: by mail-pj1-x1034.google.com with SMTP id fa1so1664605pjb.0 for ; Tue, 15 Sep 2020 05:00:51 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:subject:message-id:mime-version :content-disposition:user-agent; bh=5EhjD7feFhIv56e8krZCblSx0NshRP8K0TgMXyYyRLY=; b=aBA5y/kFGOJJprlB5dMBpbNan8R1UKjWAQRjQqSU8zPwRX8spzbn/BZkueObmMjIj7 fZhtB4xp0rVKkuA1CMkv0nrNWnaLTWBnIjmgprclQNm9iPaupNTEdK43j4B5PxqSdjKF 4N70PL8S9L5LuRzqLc4+uIv5lC14adFTZpAoLeG5xbE8PpHj1G/TArHooyr+rvSviyNX mYMiNlLWSRKvkeaRPwYSp2ke0kYWJhVswFuS8Hy1ae1aszANBWbpm9reqZ4bC6a+zNjW cfW0i++ZELbu3nBjidBs8Ayr79xNc+6sPDVVRVWQmepUw/e/lfvBmijEIFRMjmF6xiRW 2xTA== X-Gm-Message-State: AOAM530j2P91SV5CCJf90Zw6ZErBrWihHiaPdwO22Xz9BQZDAYnfccsx iy64HroC3GAkZ5jKO8oPeSb7R88xGWM= X-Google-Smtp-Source: ABdhPJxdOJCqkRvOpev+MMYqzHWhA8v4MDnFH/bM9hAwhzbcQFTZbQYB6jFEisQDOIFfTsBnMnSIpQ== X-Received: by 2002:a17:90a:f3d1:: with SMTP id ha17mr3721039pjb.231.1600171250498; Tue, 15 Sep 2020 05:00:50 -0700 (PDT) Received: from bubble.grove.modra.org (158.106.96.58.static.exetel.com.au. [58.96.106.158]) by smtp.gmail.com with ESMTPSA id e62sm13314432pfh.76.2020.09.15.05.00.49 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 15 Sep 2020 05:00:49 -0700 (PDT) Received: by bubble.grove.modra.org (Postfix, from userid 1000) id A09C4826E4; Tue, 15 Sep 2020 21:30:45 +0930 (ACST) Date: Tue, 15 Sep 2020 21:30:45 +0930 From: Alan Modra To: binutils@sourceware.org Subject: PR26610, ARM's "VFPv3 vldr to vmov" gas testcase fail Message-ID: <20200915120045.GK5452@bubble.grove.modra.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline User-Agent: Mutt/1.9.4 (2018-02-28) X-Spam-Status: No, score=-12.4 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, FREEMAIL_FROM, GIT_PATCH_0, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: binutils@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Binutils mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 15 Sep 2020 12:00:53 -0000 I removed a few too many parentheses in git commit 7af677524e2. This patch fixes that problem, rewriting the expression so it won't happen again. The patch also avoids more UB with shifts of signed values. PR 26610 * config/tc-arm.c (move_or_literal_pool): Correct extraction of bignum. Use unsigned "v" (is_double_a_single): Make "v" and "mantissa" unsigned. Formatting. (double_to_single): Likewise. diff --git a/gas/config/tc-arm.c b/gas/config/tc-arm.c index a645ffec90..32feaa1ca0 100644 --- a/gas/config/tc-arm.c +++ b/gas/config/tc-arm.c @@ -8757,25 +8757,25 @@ neon_cmode_for_move_imm (unsigned immlo, unsigned immhi, int float_p, to single precision without loss of accuracy. */ static bfd_boolean -is_double_a_single (bfd_int64_t v) +is_double_a_single (bfd_uint64_t v) { - int exp = (int)((v >> 52) & 0x7FF); - bfd_int64_t mantissa = (v & (bfd_int64_t)0xFFFFFFFFFFFFFULL); + int exp = (v >> 52) & 0x7FF; + bfd_uint64_t mantissa = v & 0xFFFFFFFFFFFFFULL; - return (exp == 0 || exp == 0x7FF - || (exp >= 1023 - 126 && exp <= 1023 + 127)) - && (mantissa & 0x1FFFFFFFl) == 0; + return ((exp == 0 || exp == 0x7FF + || (exp >= 1023 - 126 && exp <= 1023 + 127)) + && (mantissa & 0x1FFFFFFFL) == 0); } /* Returns a double precision value casted to single precision (ignoring the least significant bits in exponent and mantissa). */ static int -double_to_single (bfd_int64_t v) +double_to_single (bfd_uint64_t v) { unsigned int sign = (v >> 63) & 1; int exp = (v >> 52) & 0x7FF; - bfd_int64_t mantissa = (v & (bfd_int64_t) 0xFFFFFFFFFFFFFULL); + bfd_uint64_t mantissa = v & 0xFFFFFFFFFFFFFULL; if (exp == 0x7FF) exp = 0xFF; @@ -8848,9 +8848,9 @@ move_or_literal_pool (int i, enum lit_type t, bfd_boolean mode_3) || inst.relocs[0].exp.X_op == O_big) { #if defined BFD_HOST_64_BIT - bfd_int64_t v; + bfd_uint64_t v; #else - offsetT v; + valueT v; #endif if (inst.relocs[0].exp.X_op == O_big) { @@ -8867,16 +8867,17 @@ move_or_literal_pool (int i, enum lit_type t, bfd_boolean mode_3) l = generic_bignum; #if defined BFD_HOST_64_BIT - v = ((((bfd_uint64_t) l[3] & LITTLENUM_MASK) - << LITTLENUM_NUMBER_OF_BITS) - | (((bfd_int64_t) l[2] & LITTLENUM_MASK) - << LITTLENUM_NUMBER_OF_BITS) - | (((bfd_uint64_t) l[1] & LITTLENUM_MASK) - << LITTLENUM_NUMBER_OF_BITS) - | (l[0] & LITTLENUM_MASK)); + v = l[3] & LITTLENUM_MASK; + v <<= LITTLENUM_NUMBER_OF_BITS; + v |= l[2] & LITTLENUM_MASK; + v <<= LITTLENUM_NUMBER_OF_BITS; + v |= l[1] & LITTLENUM_MASK; + v <<= LITTLENUM_NUMBER_OF_BITS; + v |= l[0] & LITTLENUM_MASK; #else - v = ((((valueT) l[1] & LITTLENUM_MASK) << LITTLENUM_NUMBER_OF_BITS) - | (l[0] & LITTLENUM_MASK)); + v = l[1] & LITTLENUM_MASK; + v <<= LITTLENUM_NUMBER_OF_BITS; + v |= l[0] & LITTLENUM_MASK; #endif } else -- Alan Modra Australia Development Lab, IBM