From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pl1-x635.google.com (mail-pl1-x635.google.com [IPv6:2607:f8b0:4864:20::635]) by sourceware.org (Postfix) with ESMTPS id 2E8003857C53 for ; Wed, 16 Sep 2020 07:14:52 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 2E8003857C53 Received: by mail-pl1-x635.google.com with SMTP id c3so2704839plz.5 for ; Wed, 16 Sep 2020 00:14:52 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:subject:message-id:mime-version :content-disposition:user-agent; bh=+12gHmhvde3i7HjVigRX+f55bQ+Mx9mfpg49Rw0G+NM=; b=hih+f4xVwpG5SGg6t8GFA3/oXVauoYd+Gi2IRBhAaccP3ZCAMmXYASkeDFOqFnsJbK drZsJsAUXsB+EzWRvwPn48ZQKYNPdtD2wQMgNIxW/fLMb5vYBvCwQXl6SEppPlxer69F Jb/HYY0vs1CLfz/cOqpj02+PxoY+a1ixP7sxRfcqpKWQTBBv64ivCmo8C46O3MiydzYi jGFHeNTCJW0ZZu8uSQFJZ2LSABMHbI7FiFZPquCteZKemH4YVfWPOTauqGvjpvNXcsss UmVcgsmRIespJ6fzm1AJFxQmw+yY1v/mZyX20mYwh5Khv9DA5j5TmY0ODQq5JhEYOjoe m+eg== X-Gm-Message-State: AOAM5310eYe31Nu8e7sVO+BzDVUXeLjuxhSlvYZj+lcKV5nK8Ytn8x2I hB1fS+MS0jiB7NusKTa2bgyC7s3KRqM= X-Google-Smtp-Source: ABdhPJxZ6loMhL1tVGYZ5Av/izZ2k0EtZl3YdlvwQk1lv5R0UF/J7IC4xCaDjc5jJ0JUoAinvb6bYA== X-Received: by 2002:a17:902:700a:b029:d1:e5e7:be1e with SMTP id y10-20020a170902700ab02900d1e5e7be1emr5233472plk.81.1600240490982; Wed, 16 Sep 2020 00:14:50 -0700 (PDT) Received: from bubble.grove.modra.org (158.106.96.58.static.exetel.com.au. [58.96.106.158]) by smtp.gmail.com with ESMTPSA id z1sm11465686pfq.102.2020.09.16.00.14.49 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 16 Sep 2020 00:14:49 -0700 (PDT) Received: by bubble.grove.modra.org (Postfix, from userid 1000) id 4D32B863D6; Wed, 16 Sep 2020 16:44:45 +0930 (ACST) Date: Wed, 16 Sep 2020 16:44:45 +0930 From: Alan Modra To: binutils@sourceware.org Subject: PR26623, buffer overflow in ppc_symbol_is_valid Message-ID: <20200916071444.GL5452@bubble.grove.modra.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline User-Agent: Mutt/1.9.4 (2018-02-28) X-Spam-Status: No, score=-12.4 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, FREEMAIL_FROM, GIT_PATCH_0, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: binutils@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Binutils mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 16 Sep 2020 07:14:53 -0000 Synthetic symbols are not elf_symbol_type symbols. PR 26623 * elf-bfd.h (elf_symbol_from): Exclude synthetic symbols. diff --git a/bfd/elf-bfd.h b/bfd/elf-bfd.h index eebdf9ac73..9b0a2028d3 100644 --- a/bfd/elf-bfd.h +++ b/bfd/elf-bfd.h @@ -792,7 +792,8 @@ struct elf_size_info { }; #define elf_symbol_from(ABFD,S) \ - (((S)->the_bfd != NULL \ + ((((S)->flags & BSF_SYNTHETIC) == 0 \ + && (S)->the_bfd != NULL \ && (S)->the_bfd->xvec->flavour == bfd_target_elf_flavour \ && (S)->the_bfd->tdata.elf_obj_data != 0) \ ? (elf_symbol_type *) (S) \ -- Alan Modra Australia Development Lab, IBM