From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pf1-x441.google.com (mail-pf1-x441.google.com [IPv6:2607:f8b0:4864:20::441]) by sourceware.org (Postfix) with ESMTPS id 89CDE3861870 for ; Mon, 21 Sep 2020 09:16:37 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 89CDE3861870 Received: by mail-pf1-x441.google.com with SMTP id f18so8721293pfa.10 for ; Mon, 21 Sep 2020 02:16:37 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=DVcQloRXSsJ0FB7C9ZLbq3QSvJg1as/hPuYq+kE6ppE=; b=TrDTvwAN+r0ir7be0uWWb4d0jsmf52aW/jNXAIaeLRoPIburE42jaDa2pOkiAgEIPo 8QkcV9o0W+pyW3yBQWvebTz3wTcdk11lbh7NuxLBBxSdPqPKQ3fKPBXznM+RbJvgnLVK p/4gZggVveCXPLsxv9kmP8eWRDHVQxdgjQuvRWPkifJn1oFqu+LPq77lPT5ImrMzkV46 u/lyWB54T6FJqwjQe/iF0cmvL9jbTEQDyzbkHNopq2J995JrQ0kCG6Zo70O0yOeMTFAW 6qI8yMe7Vxq/5ieMO0uPoJ9dPxMxupR+kNQCqZ9UNf+1zjusg1WIquIppfAIP+7PxG0a /TCw== X-Gm-Message-State: AOAM53113ze8CiwD1eGJraHl+VVYWJCP8gFNhBaw8YXG6gvVIYGT3RCG CwKWvyW44yxOVf2fO0JoZKbfIe9astc= X-Google-Smtp-Source: ABdhPJxjWFk1GGcm2mfRLMXVYNPgaeQsT+29jxEd1Yvxc99DvfIj7tcLicoh2+4pvfq7tJYWOHyYcQ== X-Received: by 2002:a62:fc07:0:b029:142:2501:34f5 with SMTP id e7-20020a62fc070000b0290142250134f5mr26678630pfh.78.1600679796676; Mon, 21 Sep 2020 02:16:36 -0700 (PDT) Received: from bubble.grove.modra.org (158.106.96.58.static.exetel.com.au. [58.96.106.158]) by smtp.gmail.com with ESMTPSA id g1sm9967371pjs.30.2020.09.21.02.16.35 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 21 Sep 2020 02:16:35 -0700 (PDT) Received: by bubble.grove.modra.org (Postfix, from userid 1000) id 2507885B21; Mon, 21 Sep 2020 18:46:32 +0930 (ACST) Date: Mon, 21 Sep 2020 18:46:32 +0930 From: Alan Modra To: Philippe Antoine Cc: binutils@sourceware.org Subject: Re: oss-fuzz: binutils: Fuzzing build failure Message-ID: <20200921091631.GY5452@bubble.grove.modra.org> References: <0=1d79688ba06d41b624f807a991e6c9ee=59d48433e0764783d31f65a1dd0c2b85=oss-fuzz@monorail-prod.appspotmail.com> <0000000000001f161f0598158d92@google.com> <411708c7-7c97-9a48-c072-1f1c1109c3c7@redhat.com> <0FBB84B3-27CB-4884-8AB5-0216EA447A28@catenacyber.fr> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.9.4 (2018-02-28) X-Spam-Status: No, score=-12.4 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, FREEMAIL_FROM, GIT_PATCH_0, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: binutils@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Binutils mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 21 Sep 2020 09:16:38 -0000 On Fri, Sep 18, 2020 at 09:14:42PM +0200, Philippe Antoine wrote: > Latest clang introduced a new warning again. > And it found a bug in binutils, preventing the oss-fuzz build Thanks, I committed a variation on your patch, trimming off trailing commas too. * rx-dis.c (flag_names): Add missing comma. (register_names, flag_names, double_register_names), (double_register_high_names, double_register_low_names), (double_control_register_names, double_condition_names): Remove trailing commas. diff --git a/opcodes/rx-dis.c b/opcodes/rx-dis.c index 29ba71c121..1e5591ca98 100644 --- a/opcodes/rx-dis.c +++ b/opcodes/rx-dis.c @@ -85,7 +85,7 @@ static char const * register_names[] = "psw", "pc", "usp", "fpsw", NULL, NULL, NULL, NULL, "bpsw", "bpc", "isp", "fintv", "intb", "extb", NULL, NULL, "a0", "a1", NULL, NULL, NULL, NULL, NULL, NULL, - NULL, NULL, NULL, NULL, NULL, NULL, NULL, NULL, + NULL, NULL, NULL, NULL, NULL, NULL, NULL, NULL }; static char const * condition_names[] = @@ -99,36 +99,36 @@ static const char * flag_names[] = { "c", "z", "s", "o", "", "", "", "", "", "", "", "", "", "", "", "", - "i", "u", "", "", "", "", "", "" - "", "", "", "", "", "", "", "", + "i", "u", "", "", "", "", "", "", + "", "", "", "", "", "", "", "" }; static const char * double_register_names[] = { "dr0", "dr1", "dr2", "dr3", "dr4", "dr5", "dr6", "dr7", - "dr8", "dr9", "dr10", "dr11", "dr12", "dr13", "dr14", "dr15", + "dr8", "dr9", "dr10", "dr11", "dr12", "dr13", "dr14", "dr15" }; static const char * double_register_high_names[] = { "drh0", "drh1", "drh2", "drh3", "drh4", "drh5", "drh6", "drh7", - "drh8", "drh9", "drh10", "drh11", "drh12", "drh13", "drh14", "drh15", + "drh8", "drh9", "drh10", "drh11", "drh12", "drh13", "drh14", "drh15" }; static const char * double_register_low_names[] = { "drl0", "drl1", "drl2", "drl3", "drl4", "drl5", "drl6", "drl7", - "drl8", "drl9", "drl10", "drl11", "drl12", "drl13", "drl14", "drl15", + "drl8", "drl9", "drl10", "drl11", "drl12", "drl13", "drl14", "drl15" }; static const char * double_control_register_names[] = { - "dpsw", "dcmr", "decnt", "depc", + "dpsw", "dcmr", "decnt", "depc" }; static const char * double_condition_names[] = { - "", "un", "eq", "", "lt", "", "le", + "", "un", "eq", "", "lt", "", "le" }; static inline const char * -- Alan Modra Australia Development Lab, IBM