From: Jozef Lawrynowicz <jozef.l@mittosystems.com>
To: Alan Modra <amodra@gmail.com>
Cc: binutils@sourceware.org
Subject: Re: [PATCH] Support SHF_GNU_RETAIN ELF section flag
Date: Wed, 23 Sep 2020 17:54:09 +0100 [thread overview]
Message-ID: <20200923165409.vecmvy66ckocel3s@jozef-acer-manjaro> (raw)
In-Reply-To: <20200923135904.GF5452@bubble.grove.modra.org>
On Wed, Sep 23, 2020 at 11:29:05PM +0930, Alan Modra via Binutils wrote:
> On Wed, Sep 23, 2020 at 01:13:48PM +0100, Jozef Lawrynowicz wrote:
> > Attached a revised patch:
> > - Removed mmix-*-* XFAILs
> > - Fixed SHF_GNU_RETAIN being clobbered when using the .section directive
> > without the "R" flag, after the section has previously been marked
> > with SHF_GNU_RETAIN. Added tests for this behavior.
>
> In my quick scan over your patch, I didn't see anything that would set
> ELFOSABI_GNU. Since SHF_GNU_RETAIN is in the SHF_MASKOS range,
> generating sections with the flag set should also set OSABI, and
> if an object has the wrong OSABI you can't interpret that bit as
> SHF_GNU_RETAIN. See has_gnu_osabi for the way this is handled in
> bfd.
Ah yes, I'll fix that.
Thanks,
Jozef
next prev parent reply other threads:[~2020-09-23 16:54 UTC|newest]
Thread overview: 37+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-22 20:29 Jozef Lawrynowicz
2020-09-22 23:24 ` Hans-Peter Nilsson
2020-09-22 23:58 ` H.J. Lu
2020-09-23 1:09 ` Fangrui Song
2020-09-23 9:58 ` Jozef Lawrynowicz
2020-09-23 13:39 ` H.J. Lu
2020-09-23 13:51 ` Michael Matz
2020-09-23 16:52 ` Jozef Lawrynowicz
2020-09-23 17:13 ` H.J. Lu
2020-09-23 18:47 ` Jozef Lawrynowicz
2020-09-23 19:03 ` H.J. Lu
2020-09-23 20:04 ` Jozef Lawrynowicz
2020-09-23 20:17 ` H.J. Lu
2020-09-23 23:29 ` Fangrui Song
2020-09-24 11:39 ` Jozef Lawrynowicz
2020-09-24 19:06 ` Fangrui Song
2020-09-24 13:27 ` Michael Matz
2020-09-24 13:18 ` H.J. Lu
2020-09-24 13:49 ` Jozef Lawrynowicz
2020-09-24 13:59 ` H.J. Lu
2020-09-24 16:56 ` Jozef Lawrynowicz
2020-09-24 17:04 ` H.J. Lu
2020-09-24 17:18 ` Jozef Lawrynowicz
2020-09-24 17:37 ` H.J. Lu
2020-09-23 12:13 ` Jozef Lawrynowicz
2020-09-23 13:59 ` Alan Modra
2020-09-23 16:54 ` Jozef Lawrynowicz [this message]
2020-09-28 11:35 ` Pedro Alves
2020-09-28 12:28 ` Jozef Lawrynowicz
2020-09-28 14:46 ` Pedro Alves
2020-09-29 13:18 ` Michael Matz
2020-09-29 13:22 ` Jozef Lawrynowicz
2020-09-29 13:48 ` Pedro Alves
2020-09-29 13:55 ` Michael Matz
2020-09-29 14:04 ` Pedro Alves
2020-09-29 14:10 ` Michael Matz
2020-09-29 14:11 ` Pedro Alves
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200923165409.vecmvy66ckocel3s@jozef-acer-manjaro \
--to=jozef.l@mittosystems.com \
--cc=amodra@gmail.com \
--cc=binutils@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).