From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from gnu.wildebeest.org (wildebeest.demon.nl [212.238.236.112]) by sourceware.org (Postfix) with ESMTPS id 470FD3857808 for ; Thu, 24 Sep 2020 21:13:37 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 470FD3857808 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=klomp.org Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=mark@klomp.org Received: from librem (deer0x15.wildebeest.org [172.31.17.151]) (using TLSv1.2 with cipher ADH-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by gnu.wildebeest.org (Postfix) with ESMTPSA id 30C4C30002FC; Thu, 24 Sep 2020 23:13:35 +0200 (CEST) Received: by librem (Postfix, from userid 1000) id C8114C019F; Thu, 24 Sep 2020 23:12:49 +0200 (CEST) Date: Thu, 24 Sep 2020 23:12:49 +0200 From: Mark Wielaard To: Nick Clifton Cc: binutils@sourceware.org Subject: Re: [PATCH 2/3] Sync libiberty and include with GCC for get_DW_UT_name. Message-ID: <20200924211249.GC5317@wildebeest.org> References: <20200923145152.27111-1-mark@klomp.org> <20200923145152.27111-2-mark@klomp.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.10.1 (2018-07-13) X-Spam-Status: No, score=-5.9 required=5.0 tests=BAYES_00, JMQ_SPF_NEUTRAL, KAM_DMARC_STATUS, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=no autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: binutils@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Binutils mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 24 Sep 2020 21:13:38 -0000 Hi Nick, On Thu, Sep 24, 2020 at 11:26:42AM +0100, Nick Clifton wrote: > > include/ChangeLog: > > > > * dwarf2.def: Add DWARF5 Unit type header encoding macros > > DW_UT_FIRST, DW_UT and DW_UT_END. > > * dwarf2.h (enum dwarf_unit_type): Removed and define using > > DW_UT_FIRST, DW_UT and DW_UT_END macros. > > (get_DW_UT_name): New function declaration. > > > > libiberty/ChangeLog: > > > > * dwarfnames.c (get_DW_UT_name): Define using DW_UT_FIRST, DW_UT > > and DW_UT_END. > > Approved - please apply. Note the convention with libiberty/ChangeLog > entries is to say "Sync with GCC" and then provide a copy of gcc's > libiberty changelog entry. Sorry, I cheated a bit and had submitted the GCC change at the same time as the binutils one and had forgotten to add the Sync with GCC to the commit message Changelog (it was actually in the ChangeLog file entry). The patch has been accepted for GCC now. I have added the same Sync with GCC to the commit message. BTW. It would be nice if binutils adopted the same method as GCC and only required the ChangeLog entries in the commit message and not require an actual ChangeLog file entry. Thanks, Mark