Re: [PATCH] Fix a warning when initializing symbol_flags

[Alan Modra <amodra@gmail.com>]

On Sat, Sep 26, 2020 at 03:30:53PM -0700, Saagar Jha wrote:
> Eleven zeroes is, as far as I can tell, the only widely-compatible,
> guaranteed-to-work way to initialize this without warnings. 

Let's do that.  I had reason today to compile binutils on an older
system with gcc-4.4.7 installed, and that warned on the current
source.

	* config/obj-elf.c (obj_elf_change_section): Rename variable to
	avoid shadowing warning.
	* symbols.c (symbol_entry_find): Init all symbol_flags fields.

diff --git a/gas/config/obj-elf.c b/gas/config/obj-elf.c
index b1c99020a3..cd457abe5e 100644
--- a/gas/config/obj-elf.c
+++ b/gas/config/obj-elf.c
@@ -762,8 +762,8 @@ obj_elf_change_section (const char *name,
 	  /* We could be repurposing an undefined symbol here: make sure we
 	     reset sy_value to look like other section symbols in order to avoid
 	     trying to incorrectly resolve this section symbol later on.  */
-	  static const expressionS expr = { .X_op = O_constant };
-	  symbol_set_value_expression (secsym, &expr);
+	  static const expressionS exp = { .X_op = O_constant };
+	  symbol_set_value_expression (secsym, &exp);
 	  symbol_set_bfdsym (secsym, sec->symbol);
 	}
       else
diff --git a/gas/symbols.c b/gas/symbols.c
index d6080886be..26dd84b126 100644
--- a/gas/symbols.c
+++ b/gas/symbols.c
@@ -196,7 +196,8 @@ static void *
 symbol_entry_find (htab_t table, const char *name)
 {
   hashval_t hash = htab_hash_string (name);
-  symbol_entry_t needle = { { { 0 }, hash, name, 0, 0, 0 } };
+  symbol_entry_t needle = { { { 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0 },
+			      hash, name, 0, 0, 0 } };
   return htab_find_with_hash (table, &needle, hash);
 }
 


-- 
Alan Modra
Australia Development Lab, IBM