From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pf1-x444.google.com (mail-pf1-x444.google.com [IPv6:2607:f8b0:4864:20::444]) by sourceware.org (Postfix) with ESMTPS id 85B233857C5E for ; Thu, 1 Oct 2020 11:39:13 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 85B233857C5E Received: by mail-pf1-x444.google.com with SMTP id l126so4222346pfd.5 for ; Thu, 01 Oct 2020 04:39:13 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=L3zPiBWaYnmiG23XAOKDe6jNGT8zMPg0nTG68/BwMTA=; b=VGruwfUqc2DFeWhp5cU6PObSqU/T1TBtelhnUFR4zKg/c/eixtDB/hawBngGzCbjSp Uyud/B2vLFCAZizyvR5XllTrAW2dtchmYtDybr0E3nIIXhK/fiys+bcVrFV/l32yVGBb AV/PFZZTPIOM7AJMx0jzJOJ3PWs5yqrXOqGgRGbwzGVQr4CR5Px0zRu0KR4tgeMQhSM4 XQvYkNL6wfxHFQ/B2ICiiHX9RT6ZUiPAdIUpOPRXE7LNqJDFMP3SI+o6YyZuQ0TNI6Zk pcgBhR4Or7cCUipYVQA4BsQky3nFng7Qtx5bawMpJUP/ppiuMwdlXlFSmI3WxBqOVA2R srOA== X-Gm-Message-State: AOAM5302Pa6y1+0Iu1vr4ZtFqdwmVN8IBubsjY7PEyxGVUKA+XEPd1or FtJHHU6qXO1HBIcKrYlvWAY= X-Google-Smtp-Source: ABdhPJxob/NFEUaaTjyVoNIAf4BaP6r9EeJjSI+7yFAm8hyHZmHh8NftbaWfmxj5K+V1VNN2O8Oa4A== X-Received: by 2002:a65:5903:: with SMTP id f3mr5852928pgu.119.1601552352738; Thu, 01 Oct 2020 04:39:12 -0700 (PDT) Received: from bubble.grove.modra.org ([2406:3400:51d:8cc0:900:a216:a1d7:553c]) by smtp.gmail.com with ESMTPSA id fu11sm5175479pjb.47.2020.10.01.04.39.11 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 01 Oct 2020 04:39:12 -0700 (PDT) Received: by bubble.grove.modra.org (Postfix, from userid 1000) id D18FB86966; Thu, 1 Oct 2020 21:09:07 +0930 (ACST) Date: Thu, 1 Oct 2020 21:09:07 +0930 From: Alan Modra To: "H.J. Lu" , Binutils Subject: Re: [PATCH v2] Support for SHF_GNU_RETAIN ELF Section Flag Message-ID: <20201001113907.GK15011@bubble.grove.modra.org> References: <20200928132613.btkqaoomv4fdnupn@jozef-acer-manjaro> <20201001105033.4eniyhry5o6epu4x@jozef-acer-manjaro> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20201001105033.4eniyhry5o6epu4x@jozef-acer-manjaro> User-Agent: Mutt/1.9.4 (2018-02-28) X-Spam-Status: No, score=-10.4 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, FREEMAIL_FROM, GIT_PATCH_0, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: binutils@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Binutils mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 01 Oct 2020 11:39:14 -0000 On Thu, Oct 01, 2020 at 11:50:33AM +0100, Jozef Lawrynowicz wrote: > --- a/bfd/elflink.c > +++ b/bfd/elflink.c > @@ -14102,7 +14102,8 @@ bfd_elf_gc_sections (bfd *abfd, struct bfd_link_info *info) > || (elf_section_data (o)->this_hdr.sh_type > == SHT_FINI_ARRAY))) > || (elf_section_data (o)->this_hdr.sh_type == SHT_NOTE > - && elf_next_in_group (o) == NULL ))) > + && elf_next_in_group (o) == NULL) > + || (elf_section_flags (o) & SHF_GNU_RETAIN))) Flag bits in SHF_MASKOS depend on OS, so this needs a test of OSABI. That can be done by checking elf_tdata (sub)->has_gnu_osabi for the appropriate bit. > { > if (!_bfd_elf_gc_mark (info, o, gc_mark_hook)) > return FALSE; > diff --git a/binutils/NEWS b/binutils/NEWS > index c0dc73d7d8..6c7d3f3953 100644 > --- a/binutils/NEWS > +++ b/binutils/NEWS > @@ -4,6 +4,10 @@ > symbol names. In addition the --demangle=