From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pg1-x543.google.com (mail-pg1-x543.google.com [IPv6:2607:f8b0:4864:20::543]) by sourceware.org (Postfix) with ESMTPS id C0B2B3858022 for ; Sun, 8 Nov 2020 01:39:18 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org C0B2B3858022 Received: by mail-pg1-x543.google.com with SMTP id x13so3987329pgp.7 for ; Sat, 07 Nov 2020 17:39:18 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=lJNJQeiBIGavXPpYJiGKa91PQdWI5OeM2Z6JFQNmEng=; b=A6qjO4Wwgc+mvFIGYLhoAjHAHxS7JvGLky4DO90+AwgYV3sSS/nn8BJi9GJ7kRQs8D kMvPw5Ghqw738/O8xt0HEo3Vh6GficNy7qrPsk4Me/LBAaHy8t7+/CPp70wifzDCG4t3 yenTRQl2+h19kEPBhlOJjGxLXTcEQscrdaA58QH3+5x2nHn4tliq98SHmiVV0VUQE71c eS5fVhBLkME48+ic8UzzdIvDRDrQwLx5ODD5dRWWa/K1iOgtaNPnrAhFx3V7DjCGBwl7 Z16MpQFC3SmD3tn1RNsruHyFNmgAUY6x+Npj+Ffu5VflyW5p1rXEK9/4QnL3tRHJJhlg VFgw== X-Gm-Message-State: AOAM530h1Ez9Ilte8o/0tS4QNG1N56twYQltUOcXWw90Di5UzxC3WZVD VtvqcWOCORL3+cJhPeGkTvrThFcjQwmMiQ== X-Google-Smtp-Source: ABdhPJzoPu58aIn9NWh4BlkHuaqbqw0Mt32nSuFtbJbPLt1Bg+qBZpReLmjZXlvsoNG2zOBobZc5MA== X-Received: by 2002:a63:50c:: with SMTP id 12mr7540479pgf.151.1604799557568; Sat, 07 Nov 2020 17:39:17 -0800 (PST) Received: from bubble.grove.modra.org (158.106.96.58.static.exetel.com.au. [58.96.106.158]) by smtp.gmail.com with ESMTPSA id 17sm6840351pfu.160.2020.11.07.17.39.15 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 07 Nov 2020 17:39:16 -0800 (PST) Received: by bubble.grove.modra.org (Postfix, from userid 1000) id 9D2E1857CF; Sun, 8 Nov 2020 12:09:11 +1030 (ACDT) Date: Sun, 8 Nov 2020 12:09:11 +1030 From: Alan Modra To: Howard Chu Cc: binutils@sourceware.org Subject: Re: [PATCH] dependency list for static libraries Message-ID: <20201108013911.GB15956@bubble.grove.modra.org> References: <9889c54b-4dd3-2275-6621-c2391cfd268d@redhat.com> <31f9062e-175d-06e9-695a-797c7ee11420@symas.com> <58620dc1-3bb9-aaae-b476-ebb613ecb627@redhat.com> <1aaf4429-074c-7912-e6e6-4d2f82d6ef10@redhat.com> <6d270cf5-4011-d916-3e5f-140bc506f807@symas.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <6d270cf5-4011-d916-3e5f-140bc506f807@symas.com> User-Agent: Mutt/1.9.4 (2018-02-28) X-Spam-Status: No, score=-7.3 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, FREEMAIL_FROM, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: binutils@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Binutils mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 08 Nov 2020 01:39:24 -0000 On Tue, Nov 03, 2020 at 03:31:49PM +0000, Howard Chu wrote: > Nick Clifton wrote: > > Hi Howard, > > > >> Whitespace fixes done, attached. > > > > Sorry for the delay in reviewing this patch. This revised form > > looks good to me, so I have gone ahead and applied it to the sources. I now see these failures. alpha-dec-vms +FAIL: ar adding library dependencies hppa-hp-hpux10 +FAIL: ar adding library dependencies i386-bsd +FAIL: ar adding library dependencies i386-msdos +FAIL: ar adding library dependencies ia64-vms +FAIL: ar adding library dependencies ns32k-netbsd +FAIL: ar adding library dependencies ns32k-pc532-mach +FAIL: ar adding library dependencies pdp11-dec-aout +FAIL: ar adding library dependencies powerpc-aix5.1 +FAIL: ar adding library dependencies powerpc-aix5.2 +FAIL: ar adding library dependencies rs6000-aix4.3.3 +FAIL: ar adding library dependencies rs6000-aix5.1 +FAIL: ar adding library dependencies rs6000-aix5.2 +FAIL: ar adding library dependencies I think these are all targets that default to --disable-plugins. The proper fix is to condition all of the added ar.c code on BFD_SUPPORTS_PLUGINS, including help text and option processing. And then of course not run the new tests if --record-libdeps is not a known ar option. -- Alan Modra Australia Development Lab, IBM