From: Borislav Petkov <bp@suse.de>
To: Alan Modra <amodra@gmail.com>
Cc: binutils@sourceware.org
Subject: Re: x86: Do not dump DS/CS segment overrides for branch hints
Date: Wed, 2 Dec 2020 12:10:43 +0100 [thread overview]
Message-ID: <20201202111043.GC25881@zn.tnic> (raw)
In-Reply-To: <20201202104519.GB25881@zn.tnic>
On Wed, Dec 02, 2020 at 11:45:19AM +0100, Borislav Petkov wrote:
> So I'm thinking for this particular case, I should simply fix
> align-branch-9.d to match the local label
>
> [0-9]+ <.L_2>
>
> because we show local labels now in .o disassembly.
Hmm, one more aspect: could it be that local labels are specified
differently for the i386-bsd target?
Because that branch.s test
.text
jz,pt .Llabel
jz,pn .Llabel
.Llabel:
dumps on x86_64 as:
00000000 <.text>:
0: 3e 74 03 je,pt 0x6
3: 2e 74 00 je,pn 0x6
but the i386-bsd target objdump says:
Disassembly of section .text:
00000000 <.Llabel-0x6>:
0: 3e 74 03 je,pt 6 <.Llabel>
3: 2e 74 00 je,pn 6 <.Llabel>
which has the local label name in <>. Leading to the test failure.
So perhaps I should not use local labels...
--
Regards/Gruss,
Boris.
SUSE Software Solutions Germany GmbH, GF: Felix Imendörffer, HRB 36809, AG Nürnberg
next prev parent reply other threads:[~2020-12-02 11:10 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-12-02 7:19 Alan Modra
2020-12-02 9:44 ` Borislav Petkov
2020-12-02 10:45 ` Borislav Petkov
2020-12-02 11:10 ` Borislav Petkov [this message]
2020-12-07 14:15 ` Maciej W. Rozycki
2020-12-07 22:16 ` Alan Modra
2020-12-07 22:38 ` Borislav Petkov
2020-12-11 23:12 ` Borislav Petkov
2020-12-13 3:35 ` Alan Modra
2020-12-13 11:56 ` Borislav Petkov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201202111043.GC25881@zn.tnic \
--to=bp@suse.de \
--cc=amodra@gmail.com \
--cc=binutils@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).