From: Borislav Petkov <bp@suse.de>
To: Alan Modra <amodra@gmail.com>
Cc: binutils@sourceware.org
Subject: Re: x86: Do not dump DS/CS segment overrides for branch hints
Date: Mon, 7 Dec 2020 23:38:51 +0100 [thread overview]
Message-ID: <20201207223851.GD16640@zn.tnic> (raw)
In-Reply-To: <20201207221624.GE10055@bubble.grove.modra.org>
On Tue, Dec 08, 2020 at 08:46:24AM +1030, Alan Modra wrote:
> > Sure, this is a non-ELF target and these do tend to do local labels
> > differently. Grep GAS sources for LOCAL_LABEL and refer Section 5.3
> > "Symbol Names" in the GAS manual to see what to look for.
> >
> > Writing generic test cases that work everywhere can be tricky at times.
>
> Yes, on x86 you should at least try one of the PE and AOUT targets as
> well as your ELF target.
Yes, I'll be testing them from now on.
> Question whether the test needs to match label output. ".*" past the
> insn mnemonic might good enough to test whatever it is you are really
> testing.
Ah, cool idea.
I'm working on fixing those test cases and will send a diff soon for you
guys to have a look.
Thank you both.
--
Regards/Gruss,
Boris.
SUSE Software Solutions Germany GmbH, GF: Felix Imendörffer, HRB 36809, AG Nürnberg
next prev parent reply other threads:[~2020-12-07 22:38 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-12-02 7:19 Alan Modra
2020-12-02 9:44 ` Borislav Petkov
2020-12-02 10:45 ` Borislav Petkov
2020-12-02 11:10 ` Borislav Petkov
2020-12-07 14:15 ` Maciej W. Rozycki
2020-12-07 22:16 ` Alan Modra
2020-12-07 22:38 ` Borislav Petkov [this message]
2020-12-11 23:12 ` Borislav Petkov
2020-12-13 3:35 ` Alan Modra
2020-12-13 11:56 ` Borislav Petkov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201207223851.GD16640@zn.tnic \
--to=bp@suse.de \
--cc=amodra@gmail.com \
--cc=binutils@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).