From: Alan Modra <amodra@gmail.com>
To: "H.J. Lu" <hjl.tools@gmail.com>
Cc: Nick Clifton <nickc@redhat.com>, Binutils <binutils@sourceware.org>
Subject: Re: V3 [PATCH] gas: Generate a new section for SHF_GNU_RETAIN
Date: Wed, 9 Dec 2020 11:07:55 +1030 [thread overview]
Message-ID: <20201209003755.GG10055@bubble.grove.modra.org> (raw)
In-Reply-To: <CAMe9rOo7JaoOo=kbn469unrdTkPLRiUB3WGB6GQSd41vYFFb5A@mail.gmail.com>
On Tue, Dec 08, 2020 at 04:05:43PM -0800, H.J. Lu wrote:
> On Tue, Dec 8, 2020 at 9:08 AM Nick Clifton <nickc@redhat.com> wrote:
> >
> > Hi H.J.
> >
> > > Can you take a look at this
> > >
> > > https://sourceware.org/pipermail/binutils/2020-December/114407.html
> >
> > I am tending towards approving this patch, although I would like to
> > see if Alan has any comments.
> >
> > I did notice however that the patch does introduce some new failures:
> >
> > GAS REGRESSION: SHF_GNU_RETAIN sections 27
> >
> > This was for:
> > m32r-elf
> > mipsisa32el-linux
> > tx39-elf
> > mips64el-openbsd
> > mipsel-linux-gnu
> > mips-sgi-irix6
> > mips64-linux
> > rx-elf .
> > s390-linux
> > score-elf
> > mips-elf
> > mips64-openbsd
> > nds32le-elf
>
> BTW, there are many extra failures for some targets. Should we
> xfail them if no one will fix them?
>
> > The mips failures appear to be because of MIPS special sections, eg:
> >
> > regexp_diff match failure
> > regexp "^ \[..\] .bss[ ]+NOBITS[ ]+[0-9a-f]+ [0-9a-f]+ [0-9a-f]+ 00 WAR.*$"
> > line " [ 4] .reginfo MIPS_REGINFO 00000000 00003c 000018 01 0 0 4"
> > regexp_diff match failure
> >
> > I have not checked the others, but I suspect that they will be similar.
> >
>
> You are right. Just some extra sections. Here is the updated patch
> with the adjusted testcase.
>
> Alan, does this patch look OK to you?
Yes, OK by me.
--
Alan Modra
Australia Development Lab, IBM
prev parent reply other threads:[~2020-12-09 0:38 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-12-04 13:52 H.J. Lu
2020-12-04 15:29 ` Jozef Lawrynowicz
2020-12-04 16:43 ` V2 " H.J. Lu
2020-12-08 12:33 ` H.J. Lu
2020-12-08 17:08 ` Nick Clifton
2020-12-09 0:05 ` V3 " H.J. Lu
2020-12-09 0:37 ` Alan Modra [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201209003755.GG10055@bubble.grove.modra.org \
--to=amodra@gmail.com \
--cc=binutils@sourceware.org \
--cc=hjl.tools@gmail.com \
--cc=nickc@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).