From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pl1-x644.google.com (mail-pl1-x644.google.com [IPv6:2607:f8b0:4864:20::644]) by sourceware.org (Postfix) with ESMTPS id 0295F3858025 for ; Wed, 9 Dec 2020 00:38:00 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 0295F3858025 Received: by mail-pl1-x644.google.com with SMTP id t6so33722plq.1 for ; Tue, 08 Dec 2020 16:38:00 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=oqNIR/dNRD/RxYBx+XkTUbDkckaxj64fknUfoXqZcOQ=; b=jb7gPRreUM9mzFhW5HpaxbQ6t+Nsjd+E/+/bsYXxy5RB6D7JEM2+RiHhtv99oP/P6j 7Ilm0MK3sUm/w8SidUGIvfSPUq1brvqzj2coIOjaRRc34W+c3oHglbN6sDT+faFG6wXw IH06BEizpbq0zK6bbCIf+8/bgSFZ0cPJBHd55W+EKBrx3xo0c87QV/YOIVoYonI+jHOk rQSSKsJquWuwsdhUogg8fBLmDmYUY3xv2BAya9yqZZsfh5OAALSu1gZULZS9+WxqFAKa PzMtIwjipJBd7zi2NXquC+novT2rGNxhbWu4tKGSNpAG4AeFM0vv8GNOVC8jNRXz5Z44 gEfA== X-Gm-Message-State: AOAM530vmQAyNruFvkwrgqtHtk36JG0QG3k/ST6Y872GzcBxxMIXXsgM h2XLLAQJfeh3SKCkOcxKZsQ7g8VXsaR5yg== X-Google-Smtp-Source: ABdhPJwoo888DIHQBjwhgf5HHBzD64qEXwdraxvvJu9mTaevx4uOgafISAPGFED4ejnBVbFjpGpW9Q== X-Received: by 2002:a17:902:6b08:b029:d6:c471:8b5b with SMTP id o8-20020a1709026b08b02900d6c4718b5bmr20593plk.78.1607474280182; Tue, 08 Dec 2020 16:38:00 -0800 (PST) Received: from bubble.grove.modra.org ([2406:3400:51d:8cc0:5cd0:fb57:f846:7fbd]) by smtp.gmail.com with ESMTPSA id w131sm372499pfc.46.2020.12.08.16.37.58 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 08 Dec 2020 16:37:58 -0800 (PST) Received: by bubble.grove.modra.org (Postfix, from userid 1000) id 45EF7812C5; Wed, 9 Dec 2020 11:07:55 +1030 (ACDT) Date: Wed, 9 Dec 2020 11:07:55 +1030 From: Alan Modra To: "H.J. Lu" Cc: Nick Clifton , Binutils Subject: Re: V3 [PATCH] gas: Generate a new section for SHF_GNU_RETAIN Message-ID: <20201209003755.GG10055@bubble.grove.modra.org> References: <20201204135254.2147243-1-hjl.tools@gmail.com> <20201204152907.mhls5ilpv47bj5fq@jozef-acer-manjaro> <865690a0-b109-5b40-b0d6-0e3ddfecf77b@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.9.4 (2018-02-28) X-Spam-Status: No, score=-4.1 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, FREEMAIL_FROM, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: binutils@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Binutils mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 09 Dec 2020 00:38:02 -0000 On Tue, Dec 08, 2020 at 04:05:43PM -0800, H.J. Lu wrote: > On Tue, Dec 8, 2020 at 9:08 AM Nick Clifton wrote: > > > > Hi H.J. > > > > > Can you take a look at this > > > > > > https://sourceware.org/pipermail/binutils/2020-December/114407.html > > > > I am tending towards approving this patch, although I would like to > > see if Alan has any comments. > > > > I did notice however that the patch does introduce some new failures: > > > > GAS REGRESSION: SHF_GNU_RETAIN sections 27 > > > > This was for: > > m32r-elf > > mipsisa32el-linux > > tx39-elf > > mips64el-openbsd > > mipsel-linux-gnu > > mips-sgi-irix6 > > mips64-linux > > rx-elf . > > s390-linux > > score-elf > > mips-elf > > mips64-openbsd > > nds32le-elf > > BTW, there are many extra failures for some targets. Should we > xfail them if no one will fix them? > > > The mips failures appear to be because of MIPS special sections, eg: > > > > regexp_diff match failure > > regexp "^ \[..\] .bss[ ]+NOBITS[ ]+[0-9a-f]+ [0-9a-f]+ [0-9a-f]+ 00 WAR.*$" > > line " [ 4] .reginfo MIPS_REGINFO 00000000 00003c 000018 01 0 0 4" > > regexp_diff match failure > > > > I have not checked the others, but I suspect that they will be similar. > > > > You are right. Just some extra sections. Here is the updated patch > with the adjusted testcase. > > Alan, does this patch look OK to you? Yes, OK by me. -- Alan Modra Australia Development Lab, IBM