* config.sub update broke powerpc-eabivle
@ 2021-01-06 22:32 Alan Modra
2021-01-06 23:18 ` Dmitry V. Levin
0 siblings, 1 reply; 2+ messages in thread
From: Alan Modra @ 2021-01-06 22:32 UTC (permalink / raw)
To: binutils, config-patches
$ ./config.sub powerpc-eabivle
Invalid configuration `powerpc-eabivle': OS `eabivle' not recognized
$ ./config.sub powerpc-unknown-eabivle
Invalid configuration `powerpc-unknown-eabivle': OS `eabivle' not recognized
Also powerpc-eabisim and probably some arm configurations.
Committed to binutils so as to not regress the 2.36 release. Is this
OK for upstream?
* config.sub: Accept OS of eabi* and gnueabi*.
diff --git a/config.sub b/config.sub
index 0cbdae6820..b0f8492348 100755
--- a/config.sub
+++ b/config.sub
@@ -2,7 +2,7 @@
# Configuration validation subroutine script.
# Copyright 1992-2021 Free Software Foundation, Inc.
-timestamp='2021-01-01'
+timestamp='2021-01-07'
# This file is free software; you can redistribute it and/or modify it
# under the terms of the GNU General Public License as published by
@@ -1687,7 +1687,7 @@ case $os in
musl* | newlib* | uclibc*)
;;
# Likewise for "kernel-libc"
- eabi | eabihf | gnueabi | gnueabihf)
+ eabi* | gnueabi*)
;;
# Now accept the basic system types.
# The portable systems comes first.
--
Alan Modra
Australia Development Lab, IBM
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: config.sub update broke powerpc-eabivle
2021-01-06 22:32 config.sub update broke powerpc-eabivle Alan Modra
@ 2021-01-06 23:18 ` Dmitry V. Levin
0 siblings, 0 replies; 2+ messages in thread
From: Dmitry V. Levin @ 2021-01-06 23:18 UTC (permalink / raw)
To: Alan Modra; +Cc: binutils, config-patches
On Thu, Jan 07, 2021 at 09:02:34AM +1030, Alan Modra wrote:
> $ ./config.sub powerpc-eabivle
> Invalid configuration `powerpc-eabivle': OS `eabivle' not recognized
> $ ./config.sub powerpc-unknown-eabivle
> Invalid configuration `powerpc-unknown-eabivle': OS `eabivle' not recognized
>
> Also powerpc-eabisim and probably some arm configurations.
> Committed to binutils so as to not regress the 2.36 release. Is this
> OK for upstream?
Thanks, I think this fixes a regression introduced by config.git commit
5e531d391852a54e7fab2d8ff55625fca514b305. Would you mind adding some
test data to testsuite/config-sub.data and submitting a patch with a
commit message appropriate for config.git (i.e. without information
specific to binutils)?
> * config.sub: Accept OS of eabi* and gnueabi*.
>
> diff --git a/config.sub b/config.sub
> index 0cbdae6820..b0f8492348 100755
> --- a/config.sub
> +++ b/config.sub
> @@ -2,7 +2,7 @@
> # Configuration validation subroutine script.
> # Copyright 1992-2021 Free Software Foundation, Inc.
>
> -timestamp='2021-01-01'
> +timestamp='2021-01-07'
>
> # This file is free software; you can redistribute it and/or modify it
> # under the terms of the GNU General Public License as published by
> @@ -1687,7 +1687,7 @@ case $os in
> musl* | newlib* | uclibc*)
> ;;
> # Likewise for "kernel-libc"
> - eabi | eabihf | gnueabi | gnueabihf)
> + eabi* | gnueabi*)
> ;;
> # Now accept the basic system types.
> # The portable systems comes first.
>
> --
> Alan Modra
> Australia Development Lab, IBM
--
ldv
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2021-01-06 23:18 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-01-06 22:32 config.sub update broke powerpc-eabivle Alan Modra
2021-01-06 23:18 ` Dmitry V. Levin
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).