From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from vmicros1.altlinux.org (vmicros1.altlinux.org [194.107.17.57]) by sourceware.org (Postfix) with ESMTP id D69B73857828 for ; Wed, 6 Jan 2021 23:18:10 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org D69B73857828 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=altlinux.org Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=ldv@altlinux.org Received: from mua.local.altlinux.org (mua.local.altlinux.org [192.168.1.14]) by vmicros1.altlinux.org (Postfix) with ESMTP id 1825972C8B0; Thu, 7 Jan 2021 02:18:10 +0300 (MSK) Received: by mua.local.altlinux.org (Postfix, from userid 508) id 085E17CC89E; Thu, 7 Jan 2021 02:18:09 +0300 (MSK) Date: Thu, 7 Jan 2021 02:18:09 +0300 From: "Dmitry V. Levin" To: Alan Modra Cc: binutils@sourceware.org, config-patches@gnu.org Subject: Re: config.sub update broke powerpc-eabivle Message-ID: <20210106231809.GA1531@altlinux.org> References: <20210106223234.GO13873@bubble.grove.modra.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210106223234.GO13873@bubble.grove.modra.org> X-Spam-Status: No, score=-13.2 required=5.0 tests=BAYES_00, GIT_PATCH_0, KAM_DMARC_STATUS, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: binutils@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Binutils mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 06 Jan 2021 23:18:16 -0000 On Thu, Jan 07, 2021 at 09:02:34AM +1030, Alan Modra wrote: > $ ./config.sub powerpc-eabivle > Invalid configuration `powerpc-eabivle': OS `eabivle' not recognized > $ ./config.sub powerpc-unknown-eabivle > Invalid configuration `powerpc-unknown-eabivle': OS `eabivle' not recognized > > Also powerpc-eabisim and probably some arm configurations. > Committed to binutils so as to not regress the 2.36 release. Is this > OK for upstream? Thanks, I think this fixes a regression introduced by config.git commit 5e531d391852a54e7fab2d8ff55625fca514b305. Would you mind adding some test data to testsuite/config-sub.data and submitting a patch with a commit message appropriate for config.git (i.e. without information specific to binutils)? > * config.sub: Accept OS of eabi* and gnueabi*. > > diff --git a/config.sub b/config.sub > index 0cbdae6820..b0f8492348 100755 > --- a/config.sub > +++ b/config.sub > @@ -2,7 +2,7 @@ > # Configuration validation subroutine script. > # Copyright 1992-2021 Free Software Foundation, Inc. > > -timestamp='2021-01-01' > +timestamp='2021-01-07' > > # This file is free software; you can redistribute it and/or modify it > # under the terms of the GNU General Public License as published by > @@ -1687,7 +1687,7 @@ case $os in > musl* | newlib* | uclibc*) > ;; > # Likewise for "kernel-libc" > - eabi | eabihf | gnueabi | gnueabihf) > + eabi* | gnueabi*) > ;; > # Now accept the basic system types. > # The portable systems comes first. > > -- > Alan Modra > Australia Development Lab, IBM -- ldv