From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from smtp.gentoo.org (mail.gentoo.org [IPv6:2001:470:ea4a:1:5054:ff:fec7:86e4]) by sourceware.org (Postfix) with ESMTP id B4ED338438A2 for ; Thu, 14 Jan 2021 20:27:32 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org B4ED338438A2 Received: from vapier (localhost [127.0.0.1]) by smtp.gentoo.org (Postfix) with SMTP id 7B9C53402D6; Thu, 14 Jan 2021 20:27:31 +0000 (UTC) Date: Thu, 14 Jan 2021 15:27:30 -0500 From: Mike Frysinger To: "H.J. Lu" Cc: Nick Clifton , Alexandre Oliva , Binutils Subject: Re: [PATCH] bfin: Skip non SEC_ALLOC section for R_BFIN_FUNCDESC Message-ID: <20210114202730.GL6938@vapier> Mail-Followup-To: "H.J. Lu" , Nick Clifton , Alexandre Oliva , Binutils References: <20210113124155.3240078-1-hjl.tools@gmail.com> <20210114060002.GI6938@vapier> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="O8/n5iBOhiUtMkxf" Content-Disposition: inline In-Reply-To: X-Spam-Status: No, score=-5.6 required=5.0 tests=BAYES_00, KAM_DMARC_STATUS, RCVD_IN_DNSWL_NONE, SPF_HELO_PASS, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: binutils@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Binutils mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 14 Jan 2021 20:27:34 -0000 --O8/n5iBOhiUtMkxf Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On 14 Jan 2021 05:28, H.J. Lu via Binutils wrote: > On Wed, Jan 13, 2021 at 10:00 PM Mike Frysinger wrote: > > On 13 Jan 2021 04:41, H.J. Lu via Binutils wrote: > > > Linker should never generate dynamic relocations for relocations in > > > non-SEC_ALLOC section which has no impact on run-time behavior. Such > > > relocations should be resolved to 0. > > > > does elf32-frv.c need the same fix ? kind of looks like it. >=20 > Yes. FRV maintainers need to take a look. well, didn't you merge this ? :) frv: Don't generate dynamic relocation for non SEC_ALLOC sections > There are many code/bug duplications in FDPIC support. > They should be merged. to be fair, Blackfin copied FRV :). we owe a ton to FRV wrt FDPIC in the toolchain & kernel. i took a look a while ago about trying to factor things out at least in gdb, but it got so invasive, and i didn't have FRV to verify against, that i ended up shelving it. i'd feel similarly about such large refactors in bfd. not sure how to even structure it. would we create files like fdpic.c/fdpic32.c ? -mike --O8/n5iBOhiUtMkxf Content-Type: application/pgp-signature; name="signature.asc" Content-Description: Digital signature -----BEGIN PGP SIGNATURE----- iQIzBAEBCAAdFiEEuQK1JxMl+JKsJRrUQWM7n+g39YEFAmAAqSoACgkQQWM7n+g3 9YEekRAA0R5Un90MqLZgJ2HTx9wcAd3A5R34c6EM8DWDvk4E7fWrwc36A1+R8vIz 6DFFVTYurnBMtUTOvX4HOqAr62bSPRuVkTYsuD+iH+REzUietdJdpbtsZDs1BACU /pU0h+YDy7O/Pko0pGZX0f4+ynqFQcGk1s0ZqF2OvxI4Vc8iCuWZ97+HHNE+sVdL ehtWs9pVWotrmG9JnXPAORaBBkdToB8sv6LiGGHmVaArPsZoWTW4BByA5aP8fj01 K9yRCh3K9Q6S38wgOo//JwkbxhWi3JZg14rXlZJVfqN2r9LiQ36GU4dy6uuf9b9J MaEs/SYgpXednW781KQEoxegd94KFZP9ZTW28qX36EbXMmVEraHmubGveL2nsOvd YU/E11ZkvLmPONF/0ENh1STo0a8aahb86QpA1Z+HPECk6XdklHwqGn9xDiu7dwrV pzh4yn3a9eIbIk1PQ3uhQINp+Bm2aio8X3eKmd/LWh14zmqZwNSjFic/Y9Y+Wdtp Gofrl0E1PkukH1RM4nAVsTjOiACtywDUy/dVjMOXqpf8JZ8OYhDt/sr7ScFLcn7I H046w1DiJSwHttTZYcpJILtB6l9vQWpd5FyFPCOri1gQMJnpEkb+7a4f4uXg3pQz q94shQbPJOwATQewT2C0BpkY4sxqI8qUXNqL/yu9hFl+FFIRRzU= =bx+X -----END PGP SIGNATURE----- --O8/n5iBOhiUtMkxf--