From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pf1-x42c.google.com (mail-pf1-x42c.google.com [IPv6:2607:f8b0:4864:20::42c]) by sourceware.org (Postfix) with ESMTPS id 834363858023 for ; Mon, 18 Jan 2021 03:53:57 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 834363858023 Received: by mail-pf1-x42c.google.com with SMTP id t29so4293278pfg.11 for ; Sun, 17 Jan 2021 19:53:57 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=xnOmaQomV1P5ZL4hgWz+DgPChL1mWGXIKc7RDrq+AKs=; b=YgEnVHISSYrZpYS9jS8RyF387veIcSniZXd57Yqlxm8dMXDMrG5A/56MPbOwlE0K9A pc+7Sxj2JbM7oCbj/JSyebWFcoKSeh7L6XePx57HT8GG5wQfKe0t6pKUdNlX8+g94iQS 6sIm+vhGwKAVy7bbLn5JwcUA53l/u26LuETgAE2SxJ55dVpd6OU7UhLMjyQWoJtkyxGv xRRjcBNUDxHzBh3V4f6QxqVCy7OSFKUjntAtw1+k0JQLBkeqTW6PvUdIsqFeg2bruN0D xdM7EIS88J5CY1tWtflraY1hsgWU7+SX2cm3rsQNsdbMf469Y2ITwYOR8XcMstgWa2li NbeQ== X-Gm-Message-State: AOAM5308u4AtKU23t/sXGIoMbOFSNO8g2w+qMYG3rLNtVqJMMcw4i3oJ BS2nB6Cb+0CIWjeFvEVEeZE= X-Google-Smtp-Source: ABdhPJziZQRCwlNSrUeT2dPL79yEvZ/jfZw5LhsWMl35nNdbGqngL3IAlMIZYt2CWJSkbTpCsqNPvQ== X-Received: by 2002:aa7:90d1:0:b029:1b6:be0:a8ec with SMTP id k17-20020aa790d10000b02901b60be0a8ecmr8141291pfk.72.1610942036707; Sun, 17 Jan 2021 19:53:56 -0800 (PST) Received: from bubble.grove.modra.org (158.106.96.58.static.exetel.com.au. [58.96.106.158]) by smtp.gmail.com with ESMTPSA id 184sm14248368pgi.92.2021.01.17.19.53.55 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 17 Jan 2021 19:53:55 -0800 (PST) Received: by bubble.grove.modra.org (Postfix, from userid 1000) id 99A4D47DA3; Mon, 18 Jan 2021 14:23:51 +1030 (ACDT) Date: Mon, 18 Jan 2021 14:23:51 +1030 From: Alan Modra To: "H.J. Lu" Cc: binutils@sourceware.org, Nick Clifton Subject: Re: [PATCH] ld/elf: Ignore section symbols when matching linkonce with comdat Message-ID: <20210118035351.GT26219@bubble.grove.modra.org> References: <20210116235124.1870265-1-hjl.tools@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210116235124.1870265-1-hjl.tools@gmail.com> User-Agent: Mutt/1.9.4 (2018-02-28) X-Spam-Status: No, score=-7.2 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, FREEMAIL_FROM, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: binutils@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Binutils mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 18 Jan 2021 03:53:59 -0000 On Sat, Jan 16, 2021 at 03:51:24PM -0800, H.J. Lu wrote: > bfd/ > > PR ld/27193 > * elflink.c (elf_create_symbuf): Also ignore section symbols. > > ld/ > > PR ld/27193 > * testsuite/ld-i386/i386.exp: Run PR ld/27193 test. > * testsuite/ld-i386/pr27193.dd: New file. > * testsuite/ld-i386/pr27193a.o.bz2: Likewise. > * testsuite/ld-i386/pr27193b.s: Likewise. OK. I do think it would have been better to wait until 2.35 branched before "ELF: Don't generate unused section symbols" was committed. -- Alan Modra Australia Development Lab, IBM