From: Alan Modra <amodra@gmail.com>
To: binutils@sourceware.org
Subject: [GOLD] powerpc assertion failure
Date: Tue, 19 Jan 2021 13:28:54 +1030 [thread overview]
Message-ID: <20210119025854.GW26219@bubble.grove.modra.org> (raw)
A testcase with only ifuncs can result in no plt section (ifunc plt
entries might instead be in iplt), which means we can get to this code
without a static link.
I'm applying this patch to mainline and the 2.36 branch.
PR 27203
* powerpc.cc (do_plt_fde_location): Remove doing_static_link
assertion.
diff --git a/gold/powerpc.cc b/gold/powerpc.cc
index e2966ef096b..ec6f950eb21 100644
--- a/gold/powerpc.cc
+++ b/gold/powerpc.cc
@@ -3946,7 +3946,6 @@ Target_powerpc<size, big_endian>::do_plt_fde_location(const Output_data* plt,
// See Output_data_glink::do_write() for glink contents.
if (len == 0)
{
- gold_assert(parameters->doing_static_link());
// Static linking may need stubs, to support ifunc and long
// branches. We need to create an output section for
// .eh_frame early in the link process, to have a place to
--
Alan Modra
Australia Development Lab, IBM
reply other threads:[~2021-01-19 2:59 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210119025854.GW26219@bubble.grove.modra.org \
--to=amodra@gmail.com \
--cc=binutils@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).