From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from gnu.wildebeest.org (wildebeest.demon.nl [212.238.236.112]) by sourceware.org (Postfix) with ESMTPS id 98E4C386F410 for ; Sat, 23 Jan 2021 23:41:48 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 98E4C386F410 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=klomp.org Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=mark@klomp.org Received: from librem (deer0x15.wildebeest.org [172.31.17.151]) (using TLSv1.2 with cipher ADH-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by gnu.wildebeest.org (Postfix) with ESMTPSA id 5E62D3000608; Sun, 24 Jan 2021 00:41:47 +0100 (CET) Received: by librem (Postfix, from userid 1000) id B2340C1618; Sun, 24 Jan 2021 00:40:40 +0100 (CET) Date: Sun, 24 Jan 2021 00:40:40 +0100 From: Mark Wielaard To: "H.J. Lu" Cc: binutils@sourceware.org, Alan Modra , Nick Clifton Subject: Re: [PATCH] dwarf5: Fix parsing DWARF-5 line number tables Message-ID: <20210123234040.GD8492@wildebeest.org> References: <20210123232935.3317513-1-hjl.tools@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210123232935.3317513-1-hjl.tools@gmail.com> User-Agent: Mutt/1.10.1 (2018-07-13) X-Spam-Status: No, score=-5.5 required=5.0 tests=BAYES_00, JMQ_SPF_NEUTRAL, KAM_DMARC_STATUS, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=no autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: binutils@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Binutils mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 23 Jan 2021 23:41:49 -0000 Hi, On Sat, Jan 23, 2021 at 03:29:34PM -0800, H.J. Lu wrote: > Advance rngs_ptr when parsing DW_RLE_offset_pair, which was missing in > > commit c3757b583d2448a5996e83e374fb96ac7938da35 > Author: Mark Wielaard > Date: Tue Aug 25 15:33:00 2020 +0100 > > Fix the linker's handling of DWARF-5 line number tables. > > OK for master and 2.36 branch? I cannot approve binutils patches, but it looks ok to me. No idea how I missed this because the code does it correct for the other cases. BTW. It would be nice to also get this on the binutils-2_35-branch an do a 2.35.2 release for those distros that won't immediately upgrade to binutils 2.36, but have already upgraded to gcc11 (like Fedora). Thanks, Mark