From: Andrew Burgess <andrew.burgess@embecosm.com>
To: gdb-patches@sourceware.org, binutils@sourceware.org
Cc: Fredrik Hederstierna <fredrik@hederstierna.com>
Subject: PING: Re: [PATCHv2 4/9] bfd/riscv: prepare to handle bare metal core dump creation
Date: Mon, 1 Feb 2021 12:03:04 +0000 [thread overview]
Message-ID: <20210201120304.GU265215@embecosm.com> (raw)
In-Reply-To: <9379a3e1af978103cfa47e869594f0df91d807ea.1611172468.git.andrew.burgess@embecosm.com>
I believe that this patch was approved here:
https://sourceware.org/pipermail/binutils/2020-December/114376.html
But I just thought I'd ping in case anyone else on the binutils side
wanted to comment.
Thanks,
Andrew
---
* Andrew Burgess <andrew.burgess@embecosm.com> [2021-01-20 20:23:10 +0000]:
> When creating a core file GDB will call the function
> elfcore_write_prstatus to write out the general purpose registers
> along with the pid/tid for the thread.
>
> However, for a bare metal RISC-V tool chain the prstatus*_t types are
> not defined so the elfcore_write_prstatus function will return NULL,
> preventing core file creation.
>
> This commit provides the `elf_backend_write_core_note' hook and uses
> the provided function to write out the ptstatus information.
>
> In order to keep changes in the non bare metal tools to a minimum, the
> provided backend function will itself return NULL when the prstatus*_t
> types are available, the consequence of this is that the generic code
> in elfcore_write_prstatus will be used just as before. But, when
> prstatus*_t is not available, the new backend function will write out
> the prstatus information using predefined offsets.
>
> This new functionality will be used by a later GDB commit that will
> add bare metal core dumps for RISC-V.
>
> bfd/ChangeLog:
>
> * elfnn-riscv.c (riscv_write_core_note): New function.
> (elf_backend_write_core_note): Define.
> ---
> bfd/ChangeLog | 6 ++++
> bfd/elfnn-riscv.c | 72 +++++++++++++++++++++++++++++++++++++++++++++++
> 2 files changed, 78 insertions(+)
>
> diff --git a/bfd/elfnn-riscv.c b/bfd/elfnn-riscv.c
> index b2ec6a29fbf..70a683b45a3 100644
> --- a/bfd/elfnn-riscv.c
> +++ b/bfd/elfnn-riscv.c
> @@ -4886,6 +4886,77 @@ _bfd_riscv_relax_section (bfd *abfd, asection *sec,
> # define PRPSINFO_OFFSET_PR_PSARGS 56
> #endif
>
> +/* Write PRSTATUS and PRPSINFO note into core file. This will be called
> + before the generic code in elf.c. By checking the compiler defines we
> + only perform any action here if the generic code would otherwise not be
> + able to help us. The intention is that bare metal core dumps (where the
> + prstatus_t and/or prpsinfo_t might not be available) will use this code,
> + while non bare metal tools will use the generic elf code. */
> +
> +static char *
> +riscv_write_core_note (bfd *abfd ATTRIBUTE_UNUSED,
> + char *buf ATTRIBUTE_UNUSED,
> + int *bufsiz ATTRIBUTE_UNUSED,
> + int note_type ATTRIBUTE_UNUSED, ...)
> +{
> + switch (note_type)
> + {
> + default:
> + return NULL;
> +
> +#if !defined (HAVE_PRPSINFO_T)
> + case NT_PRPSINFO:
> + {
> + char data[PRPSINFO_SIZE] ATTRIBUTE_NONSTRING;
> + va_list ap;
> +
> + va_start (ap, note_type);
> + memset (data, 0, sizeof (data));
> + strncpy (data + PRPSINFO_OFFSET_PR_FNAME, va_arg (ap, const char *), 16);
> +#if GCC_VERSION == 8000 || GCC_VERSION == 8001
> + DIAGNOSTIC_PUSH;
> + /* GCC 8.0 and 8.1 warn about 80 equals destination size with
> + -Wstringop-truncation:
> + https://gcc.gnu.org/bugzilla/show_bug.cgi?id=85643
> + */
> + DIAGNOSTIC_IGNORE_STRINGOP_TRUNCATION;
> +#endif
> + strncpy (data + PRPSINFO_OFFSET_PR_PSARGS, va_arg (ap, const char *), 80);
> +#if GCC_VERSION == 8000 || GCC_VERSION == 8001
> + DIAGNOSTIC_POP;
> +#endif
> + va_end (ap);
> + return elfcore_write_note (abfd, buf, bufsiz,
> + "CORE", note_type, data, sizeof (data));
> + }
> +#endif /* !HAVE_PRPSINFO_T */
> +
> +#if !defined (HAVE_PRSTATUS_T)
> + case NT_PRSTATUS:
> + {
> + char data[PRSTATUS_SIZE];
> + va_list ap;
> + long pid;
> + int cursig;
> + const void *greg;
> +
> + va_start (ap, note_type);
> + memset (data, 0, sizeof(data));
> + pid = va_arg (ap, long);
> + bfd_put_32 (abfd, pid, data + PRSTATUS_OFFSET_PR_PID);
> + cursig = va_arg (ap, int);
> + bfd_put_16 (abfd, cursig, data + PRSTATUS_OFFSET_PR_CURSIG);
> + greg = va_arg (ap, const void *);
> + memcpy (data + PRSTATUS_OFFSET_PR_REG, greg,
> + PRSTATUS_SIZE - PRSTATUS_OFFSET_PR_REG - ARCH_SIZE / 8);
> + va_end (ap);
> + return elfcore_write_note (abfd, buf, bufsiz,
> + "CORE", note_type, data, sizeof (data));
> + }
> +#endif /* !HAVE_PRSTATUS_T */
> + }
> +}
> +
> /* Support for core dump NOTE sections. */
>
> static bfd_boolean
> @@ -5000,6 +5071,7 @@ riscv_elf_obj_attrs_arg_type (int tag)
> #define elf_backend_grok_prstatus riscv_elf_grok_prstatus
> #define elf_backend_grok_psinfo riscv_elf_grok_psinfo
> #define elf_backend_object_p riscv_elf_object_p
> +#define elf_backend_write_core_note riscv_write_core_note
> #define elf_info_to_howto_rel NULL
> #define elf_info_to_howto riscv_info_to_howto_rela
> #define bfd_elfNN_bfd_relax_section _bfd_riscv_relax_section
> --
> 2.25.4
>
next prev parent reply other threads:[~2021-02-01 12:03 UTC|newest]
Thread overview: 55+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-20 20:23 [PATCHv2 0/9] Bare-metal core dumps for RISC-V Andrew Burgess
2021-01-20 20:23 ` [PATCHv2 1/9] gdb: unify parts of the Linux and FreeBSD core dumping code Andrew Burgess
2021-01-22 12:01 ` Strasuns, Mihails
2021-01-22 18:50 ` Tom Tromey
2021-02-01 11:56 ` Andrew Burgess
2021-02-09 21:52 ` Andrew Burgess
2021-01-20 20:23 ` [PATCHv2 2/9] bfd/binutils: support for gdb target descriptions in the core file Andrew Burgess
2021-01-22 10:47 ` Strasuns, Mihails
2021-01-22 19:30 ` Andrew Burgess
2021-01-25 10:11 ` Strasuns, Mihails
2021-01-25 11:20 ` Andrew Burgess
2021-02-01 12:05 ` PING: " Andrew Burgess
2021-02-01 15:10 ` Strasuns, Mihails
2021-02-01 13:29 ` Luis Machado
2021-02-10 20:45 ` Jim Wilson
2021-01-20 20:23 ` [PATCHv2 3/9] gdb: write target description into " Andrew Burgess
2021-01-22 19:15 ` Tom Tromey
2021-02-01 13:37 ` Luis Machado
2021-01-20 20:23 ` [PATCHv2 4/9] bfd/riscv: prepare to handle bare metal core dump creation Andrew Burgess
2021-02-01 12:03 ` Andrew Burgess [this message]
2021-02-01 13:48 ` Luis Machado
2021-02-01 14:44 ` Andrew Burgess
2021-02-10 20:57 ` Jim Wilson
2021-01-20 20:23 ` [PATCHv2 5/9] gdb/riscv: introduce bare metal core dump support Andrew Burgess
2021-02-01 14:05 ` Luis Machado
2021-02-03 3:04 ` Palmer Dabbelt
2021-01-20 20:23 ` [PATCHv2 6/9] bfd/binutils: add support for RISC-V CSRs in core files Andrew Burgess
2021-02-01 12:00 ` Andrew Burgess
2021-02-01 14:08 ` Luis Machado
2021-02-10 21:00 ` Jim Wilson
2021-01-20 20:23 ` [PATCHv2 7/9] gdb/riscv: make riscv target description names global Andrew Burgess
2021-02-01 14:22 ` Luis Machado
2021-01-20 20:23 ` [PATCHv2 8/9] gdb/riscv: write CSRs into baremetal core dumps Andrew Burgess
2021-02-01 14:33 ` Luis Machado
2021-01-20 20:23 ` [PATCHv2 9/9] gdb/arm: add support for bare-metal " Andrew Burgess
2021-02-01 14:51 ` Luis Machado
2021-01-22 19:28 ` [PATCHv2 0/9] Bare-metal core dumps for RISC-V Tom Tromey
2021-02-07 21:48 ` PING: " Andrew Burgess
2021-02-10 21:01 ` Jim Wilson
2021-02-15 11:14 ` Andrew Burgess
2021-02-15 17:29 ` [PATCHv3 " Andrew Burgess
2021-02-15 17:29 ` [PATCHv3 1/9] gdb: unify parts of the Linux and FreeBSD core dumping code Andrew Burgess
2021-02-15 22:56 ` Lancelot SIX
2021-02-16 16:55 ` Andrew Burgess
2021-02-15 17:29 ` [PATCHv3 2/9] bfd/binutils: support for gdb target descriptions in the core file Andrew Burgess
2021-02-15 17:29 ` [PATCHv3 3/9] gdb: write target description into " Andrew Burgess
2021-02-15 17:29 ` [PATCHv3 4/9] bfd/riscv: prepare to handle bare metal core dump creation Andrew Burgess
2021-02-15 17:29 ` [PATCHv3 5/9] gdb/riscv: introduce bare metal core dump support Andrew Burgess
2021-02-15 17:29 ` [PATCHv3 6/9] bfd/binutils: add support for RISC-V CSRs in core files Andrew Burgess
2021-02-15 17:29 ` [PATCHv3 7/9] gdb/riscv: make riscv target description names global Andrew Burgess
2021-02-15 17:29 ` [PATCHv3 8/9] gdb/riscv: write CSRs into baremetal core dumps Andrew Burgess
2021-02-15 17:29 ` [PATCHv3 9/9] gdb/arm: add support for bare-metal " Andrew Burgess
2021-03-01 10:32 ` [PATCHv3 0/9] Bare-metal core dumps for RISC-V Andrew Burgess
2021-03-01 14:45 ` Nick Clifton
2021-03-05 17:35 ` Andrew Burgess
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210201120304.GU265215@embecosm.com \
--to=andrew.burgess@embecosm.com \
--cc=binutils@sourceware.org \
--cc=fredrik@hederstierna.com \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).