From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pf1-x431.google.com (mail-pf1-x431.google.com [IPv6:2607:f8b0:4864:20::431]) by sourceware.org (Postfix) with ESMTPS id 9D98A389682C for ; Mon, 1 Mar 2021 12:35:14 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 9D98A389682C Received: by mail-pf1-x431.google.com with SMTP id d12so8859747pfo.7 for ; Mon, 01 Mar 2021 04:35:14 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=uQsBFLtZImEn6ugcDKBm97ynZJsXvPb5VQHokFA/V0c=; b=HF3cyRUm2LLKjtNEDwSe5bt+z1dzGgRJLNIXQGGRJ4OS1WmkhjCHjSiS0vWnitocnZ OJqiYmDBMkC4F7l1W2YCUG7TPzhiVzEEQACj7ZBrSKgzoPbxfRTkgIN7LHY2Momj9A7x snSxP+P1PaW3HViZZNFbI7ASlxd3UQQZ0flrJhIYI8H109rEej/bsT0tsLOrKk3H+Gwh CYumNBIFJuG99Yuj6ihT0GAydZJjvm5kKNWlHRxYQAnDU9ziQqxbrTo1uio3v0rdExYF s0EKYUN4/Q6B9gXN/bGYm3C5yRT1pyTfm1tJGZAX2+PNO+/HabWTsOfBC5wVvxz7kmJi 1FoQ== X-Gm-Message-State: AOAM530c8isvPrZHkBkoG5Sl52vTCd+f95tTXSoUldbi9fl7ShiytWme epx7KGBNDOGHPJZ0iJvV8Ro= X-Google-Smtp-Source: ABdhPJxafzEYLTC2CbetdSEH5LWwI2KE4Zj5Eeh78TyRQG4F2cVWIrvh7LgWpLBrRz/i/G5fMlWPlA== X-Received: by 2002:a63:524b:: with SMTP id s11mr13189558pgl.332.1614602113823; Mon, 01 Mar 2021 04:35:13 -0800 (PST) Received: from bubble.grove.modra.org ([2406:3400:51d:8cc0:f476:1c98:eeba:252b]) by smtp.gmail.com with ESMTPSA id c12sm16940942pjq.48.2021.03.01.04.35.12 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 01 Mar 2021 04:35:12 -0800 (PST) Received: by bubble.grove.modra.org (Postfix, from userid 1000) id 03D1041DB3; Mon, 1 Mar 2021 23:05:08 +1030 (ACDT) Date: Mon, 1 Mar 2021 23:05:08 +1030 From: Alan Modra To: Fangrui Song Cc: binutils@sourceware.org, Jozef Lawrynowicz , Nick Clifton Subject: Re: [PATCH] ld: Don't check EI_OSABI value for input SHF_GNU_RETAIN section Message-ID: <20210301123508.GG6042@bubble.grove.modra.org> References: <20210227062905.2864007-1-maskray@google.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210227062905.2864007-1-maskray@google.com> User-Agent: Mutt/1.9.4 (2018-02-28) X-Spam-Status: No, score=-3032.9 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, FREEMAIL_FROM, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: binutils@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Binutils mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 01 Mar 2021 12:35:16 -0000 On Fri, Feb 26, 2021 at 10:29:05PM -0800, Fangrui Song via Binutils wrote: > This is consistent with how ld handles STT_GNU_IFUNC/STB_GNU_UNIQUE and allows > other OSABI to adopt SHF_GNU_RETAIN. I think this is going in the wrong direction. STT_GNU_IFUNC and STB_GNU_UNIQUE, which are both in the OS specific range, shouldn't really be recognized without first checking OSABI. Let's not make that worse by allowing SHF_GNU_RETAIN too. -- Alan Modra Australia Development Lab, IBM